freebsd-nq/sys/dev/txp
Bill Paul 1ec14c6ee9 Remove call to txp_set_filter() from txp_attach(). txp_set_filter() needs
the ifp, so you can't call it before doing if_alloc(). Also, there's
really no need to call it here anyway: the code I originally ported from
OpenBSD incorrectly set the station address only once at device attach
time, instead of setting in txp_init(). This meant you couldn't change
the address with ifconfig txp0 ether xx:xx:xx:xx:xx:xx. I added the
call to txp_set_filter() in txp_init() to correct this, but forgot to
remove the call from txp_attach(). Until now, it never mattered.

With this fix, the txp driver tests good:

txp0: <3Com 3cR990-TX-97 Etherlink with 3XP Processor> port 0xb800-0xb87f mem 0xe6800000-0xe683ffff irq 12 at device 10.0 on pci0
txp0: Ethernet address: 00:01:03:d4:91:4f
2005-10-29 03:01:16 +00:00
..
3c990img.h Start each of the license/copyright comments with /*-, minor shuffle of lines 2005-01-06 01:43:34 +00:00
if_txp.c Remove call to txp_set_filter() from txp_attach(). txp_set_filter() needs 2005-10-29 03:01:16 +00:00
if_txpreg.h - Add locking and mark MPSAFE. The driver had a mutex in the softc and 2005-10-27 21:16:17 +00:00