freebsd with flexible iflib nic queues
Go to file
Konstantin Belousov 2cd5358a66 Don't clear the software flow control flag before draining for last
close or assert the bug that it is clear when leaving.

Remove an unrelated rotted comment that was attached to the buggy
clearing.

Since draining is not done in more cases, flushing is needed in more
cases, so start fixing flushing:
- do a full flush in ttydisc_close().  State what POSIX requires more
  clearly.  This was missing ttydevsw_pktnotify() calls to tell the
  devsw layer to flush.  Hardware tty drivers don't actually flush
  since they don't understand this API.
- fix 2 missing wakeups in tty_flush().  Most of the wakeups here are
  unnecessary for last close.  But ttydisc_close() did one of the
  missing ones.

This flow control bug ameliorated the design bug of requiring
potentially unbounded waits in draining.  Software flow control is the
easiest way to get an unbounded wait, and a long wait is sometimes
actually useful.  Users can type the xoff character on the receiver
and (if ixon is set on the sender) expect the output to be held until
the user is ready for more.

Hardware flow control can also give the unbounded wait, and this bug
didn't affect hardware flow control.  Unbounded waits from hardware
flow control take a more unusual configuration.  E.g., a terminal
program that controls the modem status lines, or unplugging the cable
in a configuration where this doesn't break the connection.

The design bug is still ameliorated by a newer bug in draining for
last close -- the 1 second timeout.  E.g., if the user types the
xoff character and the sender reaches last close, then output is
not resumed and the wait times out after just 1 second.  This is
broken, but preferable to an unbounded wait.  Before this change,
the output was resumed immediately and usually completed.

Submitted by:	bde
MFC after:	2 weeks
2016-01-26 14:46:39 +00:00
bin sh: Constify internal representation in expand.c. 2016-01-24 22:26:25 +00:00
cddl MFV r294816: 4986 receiving replication stream fails if any snapshot 2016-01-26 13:37:30 +00:00
contrib Use LIBADD instead of LDADD in rping's Makefile and add libcxgb4 (the 2016-01-26 01:02:19 +00:00
crypto r294563 was incomplete; re-add the client-side options as well. 2016-01-22 14:22:11 +00:00
etc Add support for automatic leap-second file updates. 2016-01-26 07:06:44 +00:00
gnu Make libgcc compilable on RISC-V. 2016-01-26 14:45:21 +00:00
include Provide new socket option TCP_CCALGOOPT, which stands for TCP congestion 2016-01-22 02:07:48 +00:00
kerberos5 DIRDEPS_BUILD: Update dependencies. 2015-12-07 23:53:01 +00:00
lib Add fenv.c for RISC-V. Copied from MIPS. 2016-01-26 14:40:41 +00:00
libexec Follow r293066 adding a generalized exec hook for RISC-V as well. 2016-01-23 11:46:52 +00:00
release Increase efiboot.img size used in ISO creation 2016-01-13 14:47:13 +00:00
rescue Fix the build after ifconfig was converted over to lib80211 in r291470 2015-11-30 16:34:13 +00:00
sbin Add "kldstat -h"; showing module sizes in hex is rather weird. 2016-01-23 12:10:16 +00:00
secure Add the openssl header for RISC-V. 2016-01-26 14:17:39 +00:00
share Fix PROGS not reading .depend files after r284288 by making DEPENDFILE work. 2016-01-25 22:29:44 +00:00
sys Don't clear the software flow control flag before draining for last 2016-01-26 14:46:39 +00:00
targets Add in DIRDEPS_BUILD support. 2016-01-07 00:19:30 +00:00
tests PID file support hasn't been committed for ggated(8) yet. Unbreak running 2016-01-14 07:39:05 +00:00
tools Fix the various qemu configs to be buildable. 2016-01-26 07:22:22 +00:00
usr.bin Disable gprof and users on RISC-V, they don't build. 2016-01-25 16:49:39 +00:00
usr.sbin Remove uathload from build due to issue with GCC 5.2.0: 2016-01-26 14:34:40 +00:00
.arcconfig Add repository.callsign, to help arcanist figure out what repo it's 2015-07-02 22:23:52 +00:00
.arclint phabricator related changes: 2015-04-20 20:33:22 +00:00
COPYRIGHT Bump copyright year. 2015-12-31 11:21:45 +00:00
LOCKS
MAINTAINERS Add interests/maintainerships + notes 2015-12-28 19:29:05 +00:00
Makefile Import mdocml CVS snapshot 20160116 2016-01-15 23:08:59 +00:00
Makefile.inc1 Correct a comment. 2016-01-11 20:27:05 +00:00
ObsoleteFiles.inc Remove leading slashes added to ObsoleteFiles.inc in r294113. 2016-01-17 00:52:28 +00:00
README README: changes and fixups 2015-04-19 07:16:44 +00:00
UPDATING Enable DSA keys by default. They were disabled in OpenSSH 6.9p1. 2016-01-21 11:10:14 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree.  See build(7)
and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The `buildkernel` and `installkernel` targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process.  See build(7), config(8),
and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
for more information.

Note: If you want to build and install the kernel with the
`buildkernel` and `installkernel` targets, you might need to build
world before.  More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf
sub-directory.  GENERIC is the default configuration used in release builds.
NOTES contains entries and documentation for all possible
devices, not just those commonly used.


Source Roadmap:
---------------

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html