d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
39aa7c9d16
freebsd-nq/usr.bin
History
Xin LI 39aa7c9d16 Correct some style nits that I have mistakenly submitted as 
suggestions which result in the last revision[*]:
	- style(9) and sysexits(3) suggests that we use EX_*
	  as exit values, instead of some other values like
	  those returned from a system call as errno.

Additionally, follow Ruslan's suggestion about style(9) and
other style improvements:
	- Since open(2) says that it returns -1 on errors,
	  explicitly determine whether it is returning -1
	  rather than whether the return value is less than
	  zero.
	- Only set rval when there is no previous error.
	  This distinguishes the first error that occours.
	- Use exit() in favor of return in main(), this is
	  suggested in old style(9), while the evolve has
	  fade the suggestion.
	- Add some NOTREACHED comments.
	- Add blank line after first { because no local variables
	  in usage()

Thanks to Ruslan for his tireless explaining of the code standards
and knowledge of the history of style(9).

[*] Pointy hat to:	me

Submitted by:	ru (with some minor changes)
Discussed with:	ru, ssouhlal
2005-01-26 15:17:25 +00:00
..
alias Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
apply Sort sections. 2005-01-18 13:43:56 +00:00
asa Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
at Sort sections. 2005-01-18 13:43:56 +00:00
atm Fix build in the !NOATM case by using the begemot library in place of 2004-09-24 22:10:34 +00:00
awk
banner Document message length limit. 2005-01-25 22:24:04 +00:00
basename Sort sections. 2005-01-18 13:43:56 +00:00
biff Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
bluetooth Sort sections. 2005-01-18 13:43:56 +00:00
brandelf Sort sections. 2005-01-18 13:43:56 +00:00
bzip2
bzip2recover Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
c89 Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
c99 Fix off-by-one error. 2005-01-14 09:21:54 +00:00
calendar Sort sections. 2005-01-18 13:43:56 +00:00
cap_mkdb Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
catman Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
chat
checknr Document input line length limit. 2005-01-25 22:32:48 +00:00
chkey Add knob NO_NIS (fka NO_YP_LIBC) and make world compileable when set. 2004-11-13 20:40:32 +00:00
chpass Sort sections. 2005-01-18 13:43:56 +00:00
cksum Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
cmp
col Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
colcrt Sort sections. 2005-01-18 13:43:56 +00:00
colldef Sort sections. 2005-01-18 13:43:56 +00:00
colrm Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
column Take a swing at using roundup(). 2005-01-25 01:35:02 +00:00
comm Document input line length limit. 2005-01-25 22:32:48 +00:00
compile_et
compress Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
csplit Document input line length limit. 2005-01-25 22:32:48 +00:00
ctags Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
cut Sort sections. 2005-01-18 13:43:56 +00:00
dig Per style.Makefile(5), don't define MAN if the only page installed 2004-09-26 09:38:08 +00:00
dirname Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
du Use 64bit 'fts_bignum' field instead of 32bit (on 32bit archs) field 2005-01-07 00:12:24 +00:00
ee Check that ee's standard input and output is a terminal. 2004-11-05 10:18:05 +00:00
elf2aout Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
elfdump Sort sections. 2005-01-18 13:43:56 +00:00
enigma Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
env Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
expand Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
false
fetch Sort sections. 2005-01-18 13:43:56 +00:00
file Update for FILE v4.12. 2004-12-28 12:29:06 +00:00
file2c
find - Make find(1) WARNS?= 6 clean 2005-01-25 14:07:25 +00:00
finger Sort sections. 2005-01-18 13:43:56 +00:00
fmt Cross-reference fold(1). 2004-08-02 11:12:13 +00:00
fold Add cross-reference to fmt(1) and a fairly standard ENVIRONMENT section. 2004-08-02 11:15:01 +00:00
from
fstat Sort sections. 2005-01-18 13:43:56 +00:00
fsync Correct some style nits that I have mistakenly submitted as 2005-01-26 15:17:25 +00:00
ftp
gcore Remove a.out support from gcore(1). 2004-11-27 06:46:48 +00:00
gencat Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
getconf Sort sections. 2005-01-18 13:43:56 +00:00
getopt Sort sections. 2005-01-18 13:43:56 +00:00
gprof Make sure to return 0 from kernel_getnfile() since if there were an 2004-10-05 23:49:27 +00:00
head Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
hesinfo Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
hexdump Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
host Per style.Makefile(5), don't define MAN if the only page installed 2004-09-26 09:38:08 +00:00
id Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
indent Fix a buffer overflow by using strncpy() instead of strcpy(). 2004-09-19 20:34:30 +00:00
ipcrm Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
ipcs Sort sections. 2005-01-18 13:43:56 +00:00
join Sort sections. 2005-01-18 13:43:56 +00:00
jot Sort sections. 2005-01-18 13:43:56 +00:00
kdump Place a function prototype correctly. 2004-09-19 14:54:35 +00:00
keylogin Deal with double whitespace. 2004-07-03 00:24:45 +00:00
keylogout
killall Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
ktrace Sort sections. 2005-01-18 13:43:56 +00:00
ktrdump Don't use an uninitialised variable when reading from a ktr alq file. 2004-09-27 05:56:57 +00:00
lam Document incorrect handling of multibyte characters. 2004-08-12 11:34:34 +00:00
last Sort sections. 2005-01-18 13:43:56 +00:00
lastcomm Introduce options list the standard way. Correct style(9) in FILES section. 2004-07-26 19:59:29 +00:00
ldd The type of some aout header types changed to uint_32, so now we need 2004-06-29 21:13:15 +00:00
leave
less
lessecho Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
lesskey
lex NODOCCOMPRESS -> NO_DOCCOMPRESS 2004-12-21 09:33:47 +00:00
limits Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
locale Use the standard section name. 2005-01-18 20:54:50 +00:00
locate Sort sections. 2005-01-18 13:43:56 +00:00
lock Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
lockf Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
logger Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
login Introduce the PRECIOUSPROG knob in bsd.prog.mk, similar 2004-11-03 18:01:21 +00:00
logins
logname - Remove useless includes 2005-01-25 14:22:20 +00:00
look Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
lorder Deal with double whitespace. 2004-07-03 00:24:45 +00:00
lsvfs spell "file system" correctly 2005-01-24 20:06:16 +00:00
m4 Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
mail Bumped document date. 2004-05-19 09:51:31 +00:00
make Sort sections. 2005-01-18 13:43:56 +00:00
makewhatis Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
mesg Sort sections. 2005-01-18 13:43:56 +00:00
minigzip Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
ministat Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
mkdep Sort sections. 2005-01-18 13:43:56 +00:00
mkfifo Sort sections. 2005-01-18 13:43:56 +00:00
mklocale Fixed xref. 2005-01-21 10:48:35 +00:00
mkstr
mktemp Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
mkuzip Sort sections. 2005-01-18 13:43:56 +00:00
msgs Cleanup: 2005-01-17 17:45:38 +00:00
mt Deal with double whitespace. 2004-07-03 00:24:45 +00:00
ncal Scheduled mdoc(7) sweep. 2005-01-11 10:32:52 +00:00
ncplist
ncplogin Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
netstat According to style.Makefile(5): 2005-01-23 12:29:46 +00:00
newgrp Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
newkey Add knob NO_NIS (fka NO_YP_LIBC) and make world compileable when set. 2004-11-13 20:40:32 +00:00
nfsstat Fix a few cases that relied on 'implicit int' (constraint violation in C99). 2004-07-11 17:37:33 +00:00
nice Sort sections. 2005-01-18 13:43:56 +00:00
nl Document input line length limit. 2005-01-25 22:32:48 +00:00
nohup Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
nslookup Per style.Makefile(5), don't define MAN if the only page installed 2004-09-26 09:38:08 +00:00
nsupdate Fix up the man file installation for the new BIND 9 sources: 2004-09-26 06:36:11 +00:00
objformat
opieinfo Introduce the PRECIOUSPROG knob in bsd.prog.mk, similar 2004-11-03 18:01:21 +00:00
opiekey
opiepasswd Introduce the PRECIOUSPROG knob in bsd.prog.mk, similar 2004-11-03 18:01:21 +00:00
pagesize
passwd Fixed xref. 2005-01-21 10:48:35 +00:00
paste Sort sections. 2005-01-18 13:43:56 +00:00
pathchk Sort sections. 2005-01-18 13:43:56 +00:00
pkill Removed bitrot. 2004-11-13 17:12:22 +00:00
pr Sort sections. 2005-01-18 13:43:56 +00:00
printenv Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
printf Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
quota Sort sections. 2005-01-18 13:43:56 +00:00
renice
rev If ferror is true, we must reset the error indicator. 2004-12-15 06:24:57 +00:00
rlogin Removed Kerberos remnants. 2005-01-21 11:09:40 +00:00
rpcgen Markup nit. 2005-01-15 11:20:51 +00:00
rpcinfo
rs Document incorrect handling of multibyte characters. 2004-07-30 00:10:52 +00:00
rsh Removed remnants of Kerberos support. 2005-01-21 11:22:34 +00:00
rup Sort SEE ALSO references (in dictionary order, ignoring case). 2004-07-04 20:55:50 +00:00
ruptime Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
rusers Sort SEE ALSO references (in dictionary order, ignoring case). 2004-07-04 20:55:50 +00:00
rwall Sort SEE ALSO references (in dictionary order, ignoring case). 2004-07-04 20:55:50 +00:00
rwho
script Deal with double whitespace. 2004-07-03 00:24:45 +00:00
sed Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
shar Sort sections. 2005-01-18 13:43:56 +00:00
showmount Sort sections. 2005-01-18 13:43:56 +00:00
smbutil
sockstat Scheduled mdoc(7) sweep. 2005-01-11 10:32:52 +00:00
split Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
stat
su Sort sections. 2005-01-18 13:43:56 +00:00
systat Sort sections. 2005-01-18 13:43:56 +00:00
tabs Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
tail Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
talk Sort sections. 2005-01-18 13:43:56 +00:00
tar Sort sections. 2005-01-18 13:43:56 +00:00
tcopy Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
tee Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
telnet NOCRYPT -> NO_CRYPT 2004-12-21 10:16:04 +00:00
tftp Sort sections. 2005-01-18 13:43:56 +00:00
time Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
tip Use a proper protoype to declare interp() and move it to tip.h. Fix an 2004-05-06 13:25:09 +00:00
top This patch merges the sort fields for both pages, so you can (for 2004-08-16 07:51:22 +00:00
touch Sort sections. 2005-01-18 13:43:56 +00:00
tput Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
tr Sort sections. 2005-01-18 13:43:56 +00:00
true
truncate Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
truss For variables that are only checked with defined(), don't provide 2004-10-24 15:33:08 +00:00
tset Sort sections. 2005-01-18 13:43:56 +00:00
tsort Document missing multibyte character support in utilities specified 2004-07-03 01:28:21 +00:00
tty
uac Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
ul Sort sections. 2005-01-18 13:43:56 +00:00
uname Sort sections. 2005-01-18 13:43:56 +00:00
unexpand Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
unifdef Sort sections. 2005-01-18 13:43:56 +00:00
uniq Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
units Sort sections. 2005-01-18 13:43:56 +00:00
unvis
usbhidaction
usbhidctl Sort sections. 2005-01-18 13:43:56 +00:00
users
uudecode Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
uuencode Sort sections. 2005-01-18 13:43:56 +00:00
uuidgen Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
vacation
vgrind Sort sections. 2005-01-18 13:43:56 +00:00
vi Replaced afterinstall: with equivalent FILES and SYMLINKS. 2004-10-18 17:16:01 +00:00
vis Nit. 2004-07-02 22:25:40 +00:00
vmstat Sort sections. 2005-01-18 13:43:56 +00:00
w Sort sections. 2005-01-18 13:43:56 +00:00
wall Mention in the BUGS section that write and wall bogusly use the sender's 2004-07-17 04:15:27 +00:00
wc Sort sections. 2005-01-18 13:43:56 +00:00
what Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
whereis Respect locale settings from the environment. 2004-07-15 08:13:56 +00:00
which Sort sections. 2005-01-18 13:43:56 +00:00
who Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
whois Bump document date before ru gets me. 2004-12-11 13:14:54 +00:00
window Sort sections. 2005-01-18 13:43:56 +00:00
write Fix a typo in comment. 2005-01-05 11:52:40 +00:00
xargs Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
xinstall - Make WARNS?= 6 clean 2005-01-25 14:34:57 +00:00
xlint Start the dreaded NOFOO -> NO_FOO conversion. 2004-12-21 08:47:35 +00:00
xstr Sort sections. 2005-01-18 13:43:56 +00:00
yacc Sort sections. 2005-01-18 13:43:56 +00:00
yes
ypcat
ypmatch
ypwhich Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
Makefile NOCRYPT -> NO_CRYPT 2004-12-21 10:16:04 +00:00
Makefile.inc