d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
46fb42dc9d
freebsd-nq/sys
History
Dimitry Andric 46fb42dc9d Fix shift overflow problem in sys/dev/ath/ath_hal/ar5210/ar5210_power.c 
and sys/dev/ath/ath_hal/ar5211/ar5211_power.c:

sys/dev/ath/ath_hal/ar5210/ar5210_power.c:36:3: warning: signed shift result (0x200000000) requires 35 bits to represent, but 'int' only has 32 bits [-Wshift-overflow]
                OS_REG_RMW_FIELD(ah, AR_SCR, AR_SCR_SLE, AR_SCR_SLE_ALLOW);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sys/dev/ath/ath_hal/ah_internal.h:472:42: note: expanded from:
                (OS_REG_READ(_a, _r) &~ (_f)) | (((_v) << _f##_S) & (_f)))
                                                       ^
sys/dev/ath/ah_osdep.h:127:49: note: expanded from:
            (bus_space_handle_t)(_ah)->ah_sh, (_reg), (_val))
                                                       ^~~~

The AR_SCR_SLE_{WAKE,SLP,NORM} values are pre-shifted in ar5210reg.h and
ar5211reg.h, while they should be unshifted, like in ar5212reg.h.  Then,
when the OS_REG_RMW_FIELD() macro shifts them again, the values will
overflow, becoming effectively zero.

MFC after: 1 week
2011-12-21 17:16:43 +00:00
..
amd64 Add comments in NOTES to say what viawd is. 2011-12-20 00:16:52 +00:00
arm ARM pmap fixes: 2011-12-15 12:14:15 +00:00
boot Make the RTC checking for QEMU even more aggressive. 2011-12-21 16:47:01 +00:00
bsm
cam Change targ(4) to use cdevpriv, instead of multiple character devices. 2011-12-13 21:26:33 +00:00
cddl opensolaris compat: fix vcmn_err so that panic(9) produces a proper message 2011-12-19 14:55:14 +00:00
compat Protect process environment variables with p_candebug(). 2011-12-04 21:43:13 +00:00
conf When building with clang, disable -Wshift-count-negative and 2011-12-21 17:01:13 +00:00
contrib Restore a feature that was present in 5.x and 6.x, and was cleared in 2011-12-20 13:53:31 +00:00
crypto Update Copyright. 2011-10-27 14:15:26 +00:00
ddb Use FOREACH_PROC_IN_SYSTEM instead of using its unrolled form. 2011-12-18 15:36:21 +00:00
dev Fix shift overflow problem in sys/dev/ath/ath_hal/ar5210/ar5210_power.c 2011-12-21 17:16:43 +00:00
fs jwd@ reported a problem via email where the old NFS client would 2011-12-21 02:45:51 +00:00
gdb kern cons: introduce infrastructure for console grabbing by kernel 2011-12-17 15:08:43 +00:00
geom replace uses of libkern gets with cngets 2011-12-17 15:26:34 +00:00
gnu Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs. 2011-11-07 15:43:11 +00:00
i386 The size passed to kmem functions should be in terms of bytes and not 2011-12-20 20:29:45 +00:00
ia64 kern cons: introduce infrastructure for console grabbing by kernel 2011-12-17 15:08:43 +00:00
isa - There's no need to overwrite the default device method with the default 2011-11-22 21:28:20 +00:00
kern ule: ensure that batch timeshare threads are scheduled fairly 2011-12-19 20:01:21 +00:00
kgssapi Add missing break statement to make sure all 3DES etypes really are treated 2011-10-10 09:13:07 +00:00
libkern retire libkern gets 2011-12-17 15:48:55 +00:00
mips Remove these locks - they aren't strictly needed and cause measurable 2011-12-20 00:33:56 +00:00
modules - Rename if_carp.ko to carp.ko. 2011-12-16 14:28:34 +00:00
net Provide ABI compatibility shim to enable configuring of addresses 2011-12-21 12:39:08 +00:00
net80211 Remove now redundant mac argument. 2011-12-17 10:32:31 +00:00
netatalk
netgraph In r191367 the need for if_free_type() was removed and a new member 2011-11-11 22:57:52 +00:00
netinet Provide ABI compatibility shim to enable configuring of addresses 2011-12-21 12:39:08 +00:00
netinet6 Provide ABI compatibility shim to enable configuring of addresses 2011-12-21 12:39:08 +00:00
netipsec Remove unused 'plen' variable. 2011-11-26 23:57:03 +00:00
netipx Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs. 2011-11-07 15:43:11 +00:00
netnatm
netncp Change ncp_scan_bindery_object() to pass a constant search string. 2011-10-16 08:44:03 +00:00
netsmb Add unicode support to msdosfs and smbfs; original pathes from imura, 2011-11-18 03:05:20 +00:00
nfs Some cleanup of BOOTP code. Initially I wanted to just change the ifioctl() 2011-12-13 07:02:48 +00:00
nfsclient jwd@ reported a problem via email where the old NFS client would 2011-12-21 02:45:51 +00:00
nfsserver Honor NFSv3 commit call (RFC 1813, Section 3.3.21) where when count is 0, 2011-12-15 02:26:53 +00:00
nlm Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs. 2011-11-07 15:43:11 +00:00
ofed Replace __signed by signed. 2011-12-13 13:38:03 +00:00
opencrypto
pc98 kern cons: introduce infrastructure for console grabbing by kernel 2011-12-17 15:08:43 +00:00
pci To save more power, switch to 10/100Mbps link when controller is 2011-11-23 23:29:18 +00:00
powerpc Support infrastructure for X11 on PS3. 2011-12-18 16:53:21 +00:00
rpc Both a crash reported on freebsd-current on Oct. 18 under the 2011-11-03 14:38:03 +00:00
security Revert the approach for skipping lockstat_probe_func call when doing 2011-12-12 23:29:32 +00:00
sparc64 Eliminate vestiges of page coloring. 2011-12-15 05:07:16 +00:00
sys Provide ABI compatibility shim to enable configuring of addresses 2011-12-21 12:39:08 +00:00
teken Link the demo application against ncursesw to make Unicode work. 2011-10-13 14:20:27 +00:00
tools Restore the comment that I removed by accident. 2011-11-09 13:26:59 +00:00
ufs Use implementation independent inoNN_t scalars for on-disk UFS structures 2011-11-09 07:48:48 +00:00
vm Move kstack_cache_entry into the private header, and make the 2011-12-16 10:56:16 +00:00
x86 Get rid of kludgy per-descriptor state handling in acpi_apm. 2011-12-05 16:08:18 +00:00
xdr
xen s/timout/timeout 2011-12-15 06:29:13 +00:00
Makefile