d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
freebsd with flexible iflib nic queues
271,467 Commits 6 Branches 133 Tags 2.6 GiB
C 60.1%
C++ 26.1%
Roff 4.9%
Shell 3%
Assembly 1.7%
Other 3.7%
5adea417d4
Go to file
Ryan Stone 5adea417d4 Fix ifa refcount leak in ifa_ifwithnet() 
In 4f6c66cc9c, ifa_ifwithnet() was changed to no longer
ifa_ref() the returned ifaddr, and instead the caller was required
to stay in the net_epoch for as long as they wanted the ifaddr
to remain valid.  However, this missed the case where an AF_LINK
lookup would call ifaddr_byindex(), which still does ifa_ref()
the ifaddr.  This would cause a refcount leak.

Fix this by inlining the relevant parts of ifaddr_byindex() here,
with the ifa_ref() call removed.  This also avoids an unnecessary
entry and exit from the net_epoch for this case.

I've audited all in-tree consumers of ifa_ifwithnet() that could
possibly perform an AF_LINK lookup and confirmed that none of them
will expect the ifaddr to have a reference that they need to
release.

MFC after: 2 months
Sponsored by: Dell Inc
Differential Revision:	https://reviews.freebsd.org/D28705
Reviewed by: melifaro
2022-01-06 15:04:24 -05:00
.cirrus-ci Cirrus-CI: add some timing info on pkg install failure 2021-08-04 15:02:00 -04:00
.github [skip ci] fix syntax in CODEOWNERS 2021-07-22 10:58:54 -06:00
bin pkgbase: Create a FreeBSD-csh package 2021-12-21 10:17:50 +01:00
cddl ctfconvert: Handle arrays of empty structs 2021-12-31 12:55:01 -05:00
contrib wpa: Import wpa_supplicant/hostapd commit b26f5c0fe 2022-01-06 10:30:51 -08:00
crypto sshd: update the libwrap patch to drop connections early 2022-01-02 18:32:30 -08:00
etc pkgbase: Create a FreeBSD-mtree package 2021-12-21 10:17:33 +01:00
gnu libdialog: Bump shared library version to 10. 2021-10-27 09:30:24 -07:00
include ipfilter: Move kernel bits to netpfil 2021-12-20 06:16:33 -08:00
kerberos5 pkgbase: Create a FreeBSD-kerberos package 2021-09-07 10:23:14 +02:00
lib file: Turns out we need xlocal.h protection 2022-01-04 14:12:59 -07:00
libexec Restore DT_DEBUG processing 2022-01-06 09:14:09 +02:00
release pkgbase: Create a FreeBSD-csh package 2021-12-21 10:17:50 +01:00
rescue rescue: include ping iff at least one of INET & INET6 is enabled 2021-12-31 13:16:30 -05:00
sbin route: remove write-only struct hostent from getaddr() 2022-01-06 10:45:44 -05:00
secure OpenSSL: Merge OpenSSL 1.1.1m 2021-12-14 16:03:52 -05:00
share bitset.9: add description of BIT_ISSET 2022-01-06 13:15:55 +01:00
stand mips: remove saf1761 2022-01-04 16:01:14 -07:00
sys Fix ifa refcount leak in ifa_ifwithnet() 2022-01-06 15:04:24 -05:00
targets Retire obsolete iscsi_initiator(4) 2021-10-26 16:17:35 -04:00
tests posixshm tests: Fix occasional largepage_mprotect failures 2022-01-03 13:00:50 -05:00
tools stress2: Added new test cases 2022-01-05 10:27:29 +01:00
usr.bin ar: accept but ignore 'T' option 2022-01-03 11:42:59 -05:00
usr.sbin bhyve: Correct unmapping of the MSI-X table BAR 2022-01-05 10:12:09 -05:00
.arcconfig Remove history.immutable from .arcconfig 2021-04-13 12:36:25 +01:00
.arclint
.cirrus.yml Cirrus-CI: build with LLVM 13 package 2021-11-18 09:57:33 -05:00
.clang-format clang-format: Add bitset loop macros 2021-09-21 12:08:01 -04:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore add exuberant ctags tags file to gitignore 2021-12-26 12:23:07 +02:00
COPYRIGHT Welcome 2022, update copyrights. 2022-01-01 09:49:49 -07:00
LOCKS
MAINTAINERS Remove myself from bhyve maintenance; ENOTIME. 2021-11-19 07:09:30 +10:00
Makefile Let powerpc64le live as not experimental architecture. 2021-12-29 14:40:35 +01:00
Makefile.inc1 test-includes: Build a library instead of a binary 2021-12-15 15:35:24 -07:00
Makefile.libcompat libcompat: Remove MIPS from list of compat libraries 2021-12-09 08:22:51 -07:00
Makefile.sys.inc
ObsoleteFiles.inc Reapply: move libc++ from /usr/lib to /lib 2021-12-30 17:08:54 +01:00
README.md sqlite3: Vendor import of sqlite3 3.37.1 2022-01-05 15:26:24 -08:00
RELNOTES RELNOTES: Note support for KTLS RX for TLS 1.3. 2021-12-14 11:02:45 -08:00
UPDATING Make CPU_SET macros compliant with other implementations 2021-12-30 12:20:32 +01:00

README.md

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Commands and libraries under the GNU General Public License (GPL) or Lesser General Public License (LGPL). Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources.
sys/arch/conf Kernel configuration files. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries.
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.