Tom Caputi
61152d1069
Fix errata #4 handling for resuming streams
...
Currently, the handling for errata #4 has two issues which allow
the checks for this issue to be bypassed using resumable sends.
The first issue is that drc->drc_fromsnapobj is not set in the
resuming code as it is in the non-resuming code. This causes
dsl_crypto_recv_key_check() to skip its checks for the
from_ivset_guid. The second issue is that resumable sends do not
clean up their on-disk state if they fail the checks in
dmu_recv_stream() that happen before any data is received.
As a result of these two bugs, a user can attempt a resumable send
of a dataset without a from_ivset_guid. This will fail the initial
dmu_recv_stream() checks, leaving a valid resume state. The send
can then be resumed, which skips those checks, allowing the receive
to be completed.
This commit fixes these issues by setting drc->drc_fromsnapobj in
the resuming receive path and by ensuring that resumablereceives
are properly cleaned up if they fail the initial dmu_recv_stream()
checks.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #9818
Closes #9829
2020-01-14 12:25:20 -08:00
..
2018-10-19 12:08:03 -07:00
2019-12-05 12:37:00 -08:00
2017-11-04 13:25:13 -07:00
2019-07-26 10:54:14 -07:00
2019-09-13 18:09:06 -07:00
2019-06-19 09:48:12 -07:00
2019-06-19 09:48:12 -07:00
2019-12-05 12:37:00 -08:00
2018-06-06 09:35:59 -07:00
2019-09-03 12:12:31 -07:00
2019-09-05 14:49:49 -07:00
2019-12-05 12:37:00 -08:00
2019-06-12 13:13:09 -07:00
2019-10-09 10:36:03 -07:00
2019-12-03 09:51:44 -08:00
2019-09-05 14:49:49 -07:00
2019-10-10 09:47:06 -07:00
2020-01-14 12:25:20 -08:00
2019-09-12 13:31:09 -07:00
2020-01-10 10:16:58 -08:00
2019-09-05 14:49:49 -07:00
2019-11-01 13:13:43 -07:00
2019-09-05 14:49:49 -07:00
2019-12-05 12:37:00 -08:00
2019-12-05 12:37:00 -08:00
2019-12-18 17:25:13 -08:00
2019-10-09 10:36:03 -07:00
2019-11-21 09:32:57 -08:00
2019-12-09 12:26:33 -08:00
2019-10-09 10:36:03 -07:00
2019-10-09 10:36:03 -07:00
2019-12-05 12:37:00 -08:00
2019-12-11 11:58:37 -08:00
2019-12-11 11:53:57 -08:00
2019-12-13 11:51:39 -08:00
2019-11-27 10:15:01 -08:00
2019-09-02 17:56:41 -07:00
2019-10-10 09:47:06 -07:00
2016-11-29 14:34:27 -08:00
2019-11-21 09:32:57 -08:00
2019-09-06 11:26:26 -07:00
2017-10-11 16:54:48 -04:00
2019-10-01 13:17:32 -07:00
2015-01-16 14:41:26 -08:00
2019-12-11 12:12:08 -08:00
2019-12-05 12:37:00 -08:00
2019-10-16 18:37:31 -07:00
2019-11-01 13:13:43 -07:00
2019-06-19 09:48:12 -07:00
2019-07-15 13:57:56 -07:00
2019-10-11 10:13:21 -07:00
2019-08-13 21:24:43 -06:00
2019-11-01 13:13:43 -07:00
2019-12-05 12:37:00 -08:00
2019-09-06 11:26:26 -07:00
2016-11-29 14:34:27 -08:00
2019-09-13 18:09:06 -07:00
2019-11-21 09:32:57 -08:00
2019-09-02 17:56:41 -07:00
2019-10-10 09:47:06 -07:00
2019-09-05 14:49:49 -07:00
2019-12-05 12:40:45 -08:00
2020-01-06 15:40:06 -08:00
2019-10-09 10:36:03 -07:00
2019-10-09 10:36:03 -07:00
2018-06-06 09:35:59 -07:00
2018-06-06 09:35:59 -07:00
2019-12-05 12:37:00 -08:00
2019-03-21 12:47:57 -07:00
2019-10-09 10:36:03 -07:00
2019-12-05 12:37:00 -08:00
2019-07-10 15:54:49 -07:00
2019-12-05 12:37:00 -08:00
2019-12-05 12:37:00 -08:00
2019-10-31 10:09:01 -07:00
2019-11-21 09:32:57 -08:00
2019-12-26 10:57:05 -08:00
2019-06-20 18:29:02 -07:00
2019-10-09 10:36:03 -07:00
2019-12-17 19:34:52 -08:00
2019-07-12 09:31:20 -07:00
2019-07-12 09:31:20 -07:00
2019-09-05 09:34:54 -07:00
2019-09-05 09:34:54 -07:00
2019-10-10 09:45:37 -07:00
2017-01-22 13:25:40 -08:00
2019-08-21 09:29:23 -07:00
2019-10-10 09:45:37 -07:00
2019-09-05 09:34:54 -07:00
2019-12-03 09:56:15 -08:00
2019-10-09 10:36:03 -07:00
2019-12-26 10:50:23 -08:00
2019-06-20 18:29:02 -07:00
2019-10-09 10:36:03 -07:00
2019-12-05 12:37:00 -08:00
2019-01-18 09:58:46 -08:00
2019-10-09 10:36:03 -07:00
2019-09-05 14:49:49 -07:00
2019-12-11 12:12:08 -08:00
2018-02-08 15:29:24 -08:00
2019-09-02 17:56:41 -07:00
2018-06-26 10:07:42 -07:00
2019-09-05 14:49:49 -07:00
2019-12-05 12:37:00 -08:00
2019-09-02 17:56:41 -07:00
2018-11-08 16:47:24 -08:00
2019-12-11 12:12:08 -08:00
2020-01-10 10:16:58 -08:00
2019-12-16 09:49:05 -08:00
2019-10-13 19:19:39 -07:00
2019-12-11 12:12:08 -08:00
2018-03-04 17:34:51 -08:00
2019-12-16 09:49:05 -08:00
2019-11-06 10:54:25 -08:00
2019-10-02 09:15:12 -07:00
2019-11-11 09:27:59 -08:00
2019-12-05 13:10:29 -08:00
2019-12-10 15:51:58 -08:00
2019-12-05 12:37:00 -08:00
2019-12-09 12:29:56 -08:00
2018-02-09 10:08:05 -08:00
2019-11-01 13:13:43 -07:00
2019-07-26 10:54:14 -07:00
2019-10-25 13:42:54 -07:00