Tom Caputi 61152d1069 Fix errata #4 handling for resuming streams
Currently, the handling for errata #4 has two issues which allow
the checks for this issue to be bypassed using resumable sends.
The first issue is that drc->drc_fromsnapobj is not set in the
resuming code as it is in the non-resuming code. This causes
dsl_crypto_recv_key_check() to skip its checks for the
from_ivset_guid. The second issue is that resumable sends do not
clean up their on-disk state if they fail the checks in
dmu_recv_stream() that happen before any data is received.

As a result of these two bugs, a user can attempt a resumable send
of a dataset without a from_ivset_guid. This will fail the initial
dmu_recv_stream() checks, leaving a valid resume state. The send
can then be resumed, which skips those checks, allowing the receive
to be completed.

This commit fixes these issues by setting drc->drc_fromsnapobj in
the resuming receive path and by ensuring that resumablereceives
are properly cleaned up if they fail the initial dmu_recv_stream()
checks.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #9818 
Closes #9829
2020-01-14 12:25:20 -08:00
..
2019-07-26 10:54:14 -07:00
2019-06-19 09:48:12 -07:00
2019-06-19 09:48:12 -07:00
2019-10-09 10:36:03 -07:00
2019-12-03 09:51:44 -08:00
2020-01-10 10:16:58 -08:00
2019-12-11 11:58:37 -08:00
2019-09-02 17:56:41 -07:00
2019-11-21 09:32:57 -08:00
2017-10-11 16:54:48 -04:00
2019-10-01 13:17:32 -07:00
2015-01-16 14:41:26 -08:00
2019-06-19 09:48:12 -07:00
2019-10-11 10:13:21 -07:00
2019-09-02 17:56:41 -07:00
2019-10-09 10:36:03 -07:00
2019-06-20 18:29:02 -07:00
2019-06-20 18:29:02 -07:00
2019-09-05 14:49:49 -07:00
2019-09-02 17:56:41 -07:00
2019-09-05 14:49:49 -07:00
2019-09-02 17:56:41 -07:00
2020-01-10 10:16:58 -08:00
2019-10-02 09:15:12 -07:00
2019-11-11 09:27:59 -08:00
2019-12-05 13:10:29 -08:00
2018-02-09 10:08:05 -08:00
2019-07-26 10:54:14 -07:00