0e6c493fec
In order for cppcheck to perform a proper analysis it needs to be aware of how the sources are compiled (source files, include paths/files, extra defines, etc). All the needed information is available from the Makefiles and can be leveraged with a generic cppcheck Makefile target. So let's add one. Additional minor changes: * Removing the cppcheck-suppressions.txt file. With cppcheck 2.3 and these changes it appears to no longer be needed. Some inline suppressions were also removed since they appear not to be needed. We can add them back if it turns out they're needed for older versions of cppcheck. * Added the ax_count_cpus m4 macro to detect at configure time how many processors are available in order to run multiple cppcheck jobs. This value is also now used as a replacement for nproc when executing the kernel interface checks. * "PHONY =" line moved in to the Rules.am file which is included at the top of all Makefile.am's. This is just convenient becase it allows us to use the += syntax to add phony targets. * One upside of this integration worth mentioning is it now allows `make cppcheck` to be run in any directory to check that subtree. * For the moment, cppcheck is not run against the FreeBSD specific kernel sources. The cppcheck-FreeBSD target will need to be implemented and testing on FreeBSD to support this. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11508
44 lines
1.4 KiB
Makefile
44 lines
1.4 KiB
Makefile
# NB: GNU Automake Manual, Chapter 8.3.5: Libtool Convenience Libraries
|
|
# These nine libraries are intermediary build components.
|
|
SUBDIRS = libavl libicp libshare libspl libtpool libzstd
|
|
CPPCHECKDIRS = libavl libicp libnvpair libshare libspl libtpool libunicode
|
|
CPPCHECKDIRS += libuutil libzfs libzfs_core libzfsbootenv libzpool libzutil
|
|
|
|
if BUILD_LINUX
|
|
SUBDIRS += libefi
|
|
CPPCHECKDIRS += libefi
|
|
endif
|
|
|
|
# libnvpair is installed as part of the final build product
|
|
# libzutil depends on it, so it must be compiled before libzutil
|
|
SUBDIRS += libnvpair
|
|
|
|
# libzutil depends on libefi if present
|
|
SUBDIRS += libzutil libunicode
|
|
|
|
# These five libraries, which are installed as the final build product,
|
|
# incorporate the eight convenience libraries given above.
|
|
DISTLIBS = libuutil libzfs_core libzfs libzpool libzfsbootenv
|
|
SUBDIRS += $(DISTLIBS)
|
|
DISTLIBS += libnvpair
|
|
|
|
# An ABI is stored for each of these libraries. Note that libzpool.so
|
|
# is only linked against by ztest and zdb and no stable ABI is provided.
|
|
ABILIBS = libnvpair libuutil libzfs_core libzfs libzfsbootenv
|
|
|
|
PHONY = checkabi storeabi cppcheck
|
|
checkabi: $(ABILIBS)
|
|
set -e ; for dir in $(ABILIBS) ; do \
|
|
$(MAKE) -C $$dir checkabi ; \
|
|
done
|
|
|
|
storeabi: $(ABILIBS)
|
|
set -e ; for dir in $(ABILIBS) ; do \
|
|
$(MAKE) -C $$dir storeabi ; \
|
|
done
|
|
|
|
cppcheck: $(CPPCHECKDIRS)
|
|
set -e ; for dir in $(CPPCHECKDIRS) ; do \
|
|
$(MAKE) -C $$dir cppcheck ; \
|
|
done
|