freebsd-nq/sys/netpfil/ipfw
Don Lewis 46c8aadb6f Change several constants used by the PIE algorithm from unsigned to signed.
- PIE_MAX_PROB is compared to variable of int64_t and the type promotion
   rules can cause the value of that variable to be treated as unsigned.
   If the value is actually negative, then the result of the comparsion
   is incorrect, causing the algorithm to perform poorly in some
   situations.  Changing the constant to be signed cause the comparision
   to work correctly.

 - PIE_SCALE is also compared to signed values.  Fortunately they are
   also compared to zero and negative values are discarded so this is
   more of a cosmetic fix.

 - PIE_DQ_THRESHOLD is only compared to unsigned values, but it is small
   enough that the automatic promotion to unsigned is harmless.

Submitted by:	Rasool Al-Saadi <ralsaadi@swin.edu.au>
MFC after:	1 week
2017-03-18 23:00:13 +00:00
..
nat64 Use memset with structure size. 2017-03-14 07:57:33 +00:00
nptv6 Fix NPTv6 rule counters when one_pass is not enabled. 2017-03-01 20:00:19 +00:00
test cleanup and document in some detail the internals of the testing code 2016-01-27 02:22:31 +00:00
dn_aqm_codel.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_aqm_codel.h Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_aqm_pie.c Fix a race condition between the main thread in aqm_pie_cleanup() and the 2016-07-05 00:53:01 +00:00
dn_aqm_pie.h Change several constants used by the PIE algorithm from unsigned to signed. 2017-03-18 23:00:13 +00:00
dn_aqm.h Correct a typo in a comment. 2016-05-26 22:03:28 +00:00
dn_heap.c
dn_heap.h Fix typos in comments (returing -> returning) 2017-02-07 00:09:48 +00:00
dn_sched_fifo.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_fq_codel_helper.h Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_fq_codel.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_fq_codel.h Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_fq_pie.c Fix problems in the FQ-PIE AQM cleanup code that could leak memory or 2016-07-12 17:32:40 +00:00
dn_sched_prio.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_qfq.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_rr.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched_wf2q.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
dn_sched.h Get closer to a VIMAGE network stack teardown from top to bottom rather 2016-06-21 13:48:49 +00:00
dummynet.txt sys/net*: minor spelling fixes. 2016-05-03 18:05:43 +00:00
ip_dn_glue.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
ip_dn_io.c Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
ip_dn_private.h Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). 2016-05-26 21:40:13 +00:00
ip_dummynet.c In dummynet(4), random chunks of memory are casted to struct dn_*, 2017-01-09 20:51:51 +00:00
ip_fw2.c Add IPv6 support to O_IP_DST_LOOKUP opcode. 2017-03-05 23:48:24 +00:00
ip_fw_bpf.c Move logging via BPF support into separate file. 2016-08-13 15:41:04 +00:00
ip_fw_dynamic.c Convert result of hash_packet6() into host byte order. 2016-12-06 23:52:56 +00:00
ip_fw_eaction.c Make named objects set-aware. Now it is possible to create named 2016-05-17 07:47:23 +00:00
ip_fw_iface.c Change the type of objhash_cb_t callback function to be able return an 2016-05-06 03:18:51 +00:00
ip_fw_log.c Use inet_ntoa_r() instead of inet_ntoa() throughout the kernel 2017-02-16 20:47:41 +00:00
ip_fw_nat.c In case of the global eventhandler make sure the current VNET 2016-06-30 19:32:45 +00:00
ip_fw_pfil.c Remove the mbuf tag after use (for reinjected packets). 2016-11-03 00:26:58 +00:00
ip_fw_private.h Add IPv6 support to O_IP_DST_LOOKUP opcode. 2017-03-05 23:48:24 +00:00
ip_fw_sockopt.c Add IPv6 support to O_IP_DST_LOOKUP opcode. 2017-03-05 23:48:24 +00:00
ip_fw_table_algo.c Fix 4-byte overflow in ipv6_writemask. 2016-06-05 10:33:53 +00:00
ip_fw_table_value.c Change the type of objhash_cb_t callback function to be able return an 2016-05-06 03:18:51 +00:00
ip_fw_table.c o Typo in the comment fixed. 2017-03-09 09:54:23 +00:00
ip_fw_table.h