002e54b0aa
Any change to a directory's contents should cause its mtime and ctime to be updated by the FUSE daemon. Clear its attribute cache so we'll get the new attributs the next time that they're needed. This affects the following VOPs: VOP_CREATE, VOP_LINK, VOP_MKDIR, VOP_MKNOD, VOP_REMOVE, VOP_RMDIR, and VOP_SYMLINK Reported by: pjdfstest Sponsored by: The FreeBSD Foundation
140 lines
4.1 KiB
C++
140 lines
4.1 KiB
C++
/*-
|
|
* Copyright (c) 2019 The FreeBSD Foundation
|
|
* All rights reserved.
|
|
*
|
|
* This software was developed by BFF Storage Systems, LLC under sponsorship
|
|
* from the FreeBSD Foundation.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
extern "C" {
|
|
#include <fcntl.h>
|
|
}
|
|
|
|
#include "mockfs.hh"
|
|
#include "utils.hh"
|
|
|
|
using namespace testing;
|
|
|
|
class Unlink: public FuseTest {
|
|
public:
|
|
void expect_getattr(uint64_t ino, mode_t mode)
|
|
{
|
|
EXPECT_CALL(*m_mock, process(
|
|
ResultOf([=](auto in) {
|
|
return (in->header.opcode == FUSE_GETATTR &&
|
|
in->header.nodeid == ino);
|
|
}, Eq(true)),
|
|
_)
|
|
).WillOnce(Invoke(ReturnImmediate([=](auto i __unused, auto out) {
|
|
SET_OUT_HEADER_LEN(out, attr);
|
|
out->body.attr.attr.ino = ino; // Must match nodeid
|
|
out->body.attr.attr.mode = mode;
|
|
out->body.attr.attr_valid = UINT64_MAX;
|
|
})));
|
|
}
|
|
|
|
void expect_lookup(const char *relpath, uint64_t ino, int times)
|
|
{
|
|
FuseTest::expect_lookup(relpath, ino, S_IFREG | 0644, 0, times);
|
|
}
|
|
|
|
};
|
|
|
|
/*
|
|
* A successful unlink should clear the parent directory's attribute cache,
|
|
* because the fuse daemon should update its mtime and ctime
|
|
*/
|
|
TEST_F(Unlink, clear_attr_cache)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
const char RELPATH[] = "some_file.txt";
|
|
struct stat sb;
|
|
uint64_t ino = 42;
|
|
|
|
EXPECT_CALL(*m_mock, process(
|
|
ResultOf([=](auto in) {
|
|
return (in->header.opcode == FUSE_GETATTR &&
|
|
in->header.nodeid == 1);
|
|
}, Eq(true)),
|
|
_)
|
|
).Times(2)
|
|
.WillRepeatedly(Invoke(ReturnImmediate([=](auto i __unused, auto out) {
|
|
SET_OUT_HEADER_LEN(out, attr);
|
|
out->body.attr.attr.ino = ino; // Must match nodeid
|
|
out->body.attr.attr.mode = S_IFDIR | 0755;
|
|
out->body.attr.attr_valid = UINT64_MAX;
|
|
})));
|
|
expect_lookup(RELPATH, ino, 1);
|
|
expect_unlink(1, RELPATH, 0);
|
|
|
|
ASSERT_EQ(0, unlink(FULLPATH)) << strerror(errno);
|
|
EXPECT_EQ(0, stat("mountpoint", &sb)) << strerror(errno);
|
|
}
|
|
|
|
TEST_F(Unlink, eperm)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
const char RELPATH[] = "some_file.txt";
|
|
uint64_t ino = 42;
|
|
|
|
expect_getattr(1, S_IFDIR | 0755);
|
|
expect_lookup(RELPATH, ino, 1);
|
|
expect_unlink(1, RELPATH, EPERM);
|
|
|
|
ASSERT_NE(0, unlink(FULLPATH));
|
|
ASSERT_EQ(EPERM, errno);
|
|
}
|
|
|
|
TEST_F(Unlink, ok)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
const char RELPATH[] = "some_file.txt";
|
|
uint64_t ino = 42;
|
|
|
|
expect_getattr(1, S_IFDIR | 0755);
|
|
expect_lookup(RELPATH, ino, 1);
|
|
expect_unlink(1, RELPATH, 0);
|
|
|
|
ASSERT_EQ(0, unlink(FULLPATH)) << strerror(errno);
|
|
}
|
|
|
|
/* Unlink an open file */
|
|
TEST_F(Unlink, open_but_deleted)
|
|
{
|
|
const char FULLPATH[] = "mountpoint/some_file.txt";
|
|
const char RELPATH[] = "some_file.txt";
|
|
uint64_t ino = 42;
|
|
int fd;
|
|
|
|
expect_getattr(1, S_IFDIR | 0755);
|
|
expect_lookup(RELPATH, ino, 2);
|
|
expect_open(ino, 0, 1);
|
|
expect_unlink(1, RELPATH, 0);
|
|
|
|
fd = open(FULLPATH, O_RDWR);
|
|
ASSERT_LE(0, fd) << strerror(errno);
|
|
ASSERT_EQ(0, unlink(FULLPATH)) << strerror(errno);
|
|
/* Deliberately leak fd. close(2) will be tested in release.cc */
|
|
}
|