96937e3b23
In revision 254095, gpt_entries is not set to match the on-disk
hdr_entries, but rather is computed based on available space.
There are 2 problems with this:
1. The GPT backend respects hdr_entries and only reads and writes
that number of partition entries. On top of that, CRC32 is
computed over the table that has hdr_entries elements. When
the common code works on what is possibly a larger number, the
behaviour becomes inconsistent and problematic. In particular,
it would be possible to add a new partition that on a reboot
isn't there anymore.
2. The calculation of gpt_entries is based on flawed assumptions.
The GPT specification does not dictate that sectors are layed
out in a particular way that the available space can be
determined by looking at LBAs. In practice, implementations
do the same thing, because there's no reason to do it any
other way. Still, GPT allows certain freedoms that can be
exploited in some form or shape if the need arises.
PR: 229977
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D19438
|
||
|---|---|---|
| .. | ||
| bde | ||
| cache | ||
| concat | ||
| eli | ||
| gate | ||
| journal | ||
| label | ||
| linux_lvm | ||
| mirror | ||
| mountver | ||
| multipath | ||
| nop | ||
| part | ||
| raid | ||
| raid3 | ||
| sched | ||
| shsec | ||
| stripe | ||
| uzip | ||
| vinum | ||
| virstor | ||
| zero | ||
| geom_bsd_enc.c | ||
| geom_bsd.c | ||
| geom_ccd.c | ||
| geom_ctl.c | ||
| geom_ctl.h | ||
| geom_dev.c | ||
| geom_disk.c | ||
| geom_disk.h | ||
| geom_dump.c | ||
| geom_event.c | ||
| geom_flashmap.c | ||
| geom_fox.c | ||
| geom_int.h | ||
| geom_io.c | ||
| geom_kern.c | ||
| geom_map.c | ||
| geom_mbr_enc.c | ||
| geom_mbr.c | ||
| geom_redboot.c | ||
| geom_slice.c | ||
| geom_slice.h | ||
| geom_subr.c | ||
| geom_sunlabel_enc.c | ||
| geom_sunlabel.c | ||
| geom_vfs.c | ||
| geom_vfs.h | ||
| geom_vol_ffs.c | ||
| geom.h | ||
| notes | ||