997452064e
- Remove a lot of superfluous locking during attach. There is no need to lock access to the driver until some other thread has a way of getting to it. For ethernet drivers the other ways include registering an interrupt handler via bus_setup_intr(), calling ether_ifattach() to hook into the network stack, and kicking off a callout-driven timer via callout_reset(). - Use callout_* rather than timeout/untimeout. - Break out of xl_rxeof() if IFF_DRV_RUNNING is clear after ifp->if_input returns to handle the case where the interface was stopped while we were passing a packet up the stack. Don't call xl_rxeof() in xl_rxeof_task() unless IFF_DRV_RUNNING is set. With these fixes in place, any outstanding task will gracefully terminate as soon as it gets a chance to run after the interface has been stopped via xl_stop(). As a result, taskqueue_drain() is no longer required in xl_stop(). The task is still drained in detach() however to make sure that detach() can safely destroy the driver mutex at the end of the function. - Lock the driver lock in the ifmedia callouts and don't lock across ifmedia_ioctl() in xl_ioctl(). Note: glebius came up with most of (3) as well independently. I took a rather roundabout way of arriving at the same conclusion. MFC after: 3 days |
||
|---|---|---|
| .. | ||
| agp_ali.c | ||
| agp_amd64.c | ||
| agp_amd.c | ||
| agp_i810.c | ||
| agp_if.m | ||
| agp_intel.c | ||
| agp_nvidia.c | ||
| agp_sis.c | ||
| agp_via.c | ||
| agp.c | ||
| agppriv.h | ||
| agpreg.h | ||
| agpvar.h | ||
| alpm.c | ||
| amdpm.c | ||
| dc21040reg.h | ||
| if_dc.c | ||
| if_dcreg.h | ||
| if_de.c | ||
| if_devar.h | ||
| if_mn.c | ||
| if_pcn.c | ||
| if_pcnreg.h | ||
| if_rl.c | ||
| if_rlreg.h | ||
| if_sf.c | ||
| if_sfreg.h | ||
| if_sis.c | ||
| if_sisreg.h | ||
| if_sk.c | ||
| if_skreg.h | ||
| if_ste.c | ||
| if_stereg.h | ||
| if_ti.c | ||
| if_tireg.h | ||
| if_tl.c | ||
| if_tlreg.h | ||
| if_vr.c | ||
| if_vrreg.h | ||
| if_wb.c | ||
| if_wbreg.h | ||
| if_xl.c | ||
| if_xlreg.h | ||
| intpm.c | ||
| intpmreg.h | ||
| locate.pl | ||
| ncr.c | ||
| ncrreg.h | ||
| ti_fw2.h | ||
| ti_fw.h | ||
| viapm.c | ||
| xmaciireg.h | ||
| xrpu.c | ||
| yukonreg.h | ||