d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
freebsd-nq/sys/netinet
History
Gleb Smirnoff 0e2bc05c47 Fix tcp_output() so that tcpcb is updated in the same manner when an 
mbuf allocation fails, as in a case when ip_output() returns error.

To achieve that, move large block of code that updates tcpcb below
the out: label.

This fixes a panic, that requires the following sequence to happen:

1) The SYN was sent to the network, tp->snd_nxt = iss + 1, tp->snd_una = iss
2) The retransmit timeout happened for the SYN we had sent,
   tcp_timer_rexmt() sets tp->snd_nxt = tp->snd_una, and calls tcp_output().
   In tcp_output m_get() fails.
3) Later on the SYN|ACK for the SYN sent in step 1) came,
   tcp_input sets tp->snd_una += 1, which leads to
   tp->snd_una > tp->snd_nxt inconsistency, that later panics in
   socket buffer code.

For reference, this bug fixed in DragonflyBSD repo:

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/1ff9b7d322dc5a26f7173aa8c38ecb79da80e419

Reviewed by:	andre
Tested by:	pho
Sponsored by:	Nginx, Inc.
PR:		kern/177456
Submitted by:	HouYeFei&XiBoLiu <lglion718 163.com>
2013-04-11 18:23:56 +00:00
..
cc
Staticize malloc types.
2011-04-13 11:28:46 +00:00
khelp
The TCP PAWS fix for kernels with fast tick rates (r231767) changed the TCP
2012-08-17 01:49:51 +00:00
libalias
In m_megapullup() instead of reserving some space at the end of packet,
2013-03-17 07:37:10 +00:00
accf_data.c
…
accf_dns.c
…
accf_http.c
Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs.
2011-11-07 15:43:11 +00:00
cc.h
Use the full and proper company name for Swinburne University of Technology
2011-04-12 08:13:18 +00:00
icmp6.h
Correct typo in the RFC number for the constants based on IANA assignments
2012-03-04 18:47:20 +00:00
icmp_var.h
Add rate limitation for SCTP OOTB responses.
2012-06-18 17:11:24 +00:00
if_atm.c
Bring back (most of) NATM to avoid further bitrot after r186119.
2010-12-15 22:58:45 +00:00
if_atm.h
…
if_ether.c
Fix problem in r238990. The LLE_LINKED flag should be tested prior to
2012-12-13 11:11:15 +00:00
if_ether.h
Retire struct sockaddr_inarp.
2013-01-31 08:55:21 +00:00
igmp_var.h
…
igmp.c
- Replace compat macros with function calls.
2013-03-16 08:58:28 +00:00
igmp.h
…
in_cksum.c
nobody uses this file except the userspace ipfw code, but the cast
2012-07-31 08:04:49 +00:00
in_debug.c
Remove last remnants of classful addressing:
2011-10-15 16:28:06 +00:00
in_gif.c
Mechanically substitute flags from historic mbuf allocator with
2012-12-05 08:04:20 +00:00
in_gif.h
…
in_mcast.c
Remove unused variable.
2012-01-24 14:27:14 +00:00
in_pcb.c
Remove redundant test, we know inp_lport is 0.
2013-01-25 20:14:27 +00:00
in_pcb.h
Change certain heavily used network related mutexes and rwlocks to
2013-04-09 21:02:20 +00:00
in_pcbgroup.c
Implement a CPU-affine TCP and UDP connection lookup data structure,
2011-06-06 12:55:02 +00:00
in_proto.c
Bunch of fixes to pfsync(4) module load/unload:
2012-01-09 08:50:22 +00:00
in_rmx.c
Cleanup documentation: cloning route support has been removed in r186119.
2012-10-13 09:31:01 +00:00
in_systm.h
…
in_var.h
Fix build.
2013-04-10 08:09:25 +00:00
in.c
Retire struct sockaddr_inarp.
2013-01-31 08:55:21 +00:00
in.h
Switch the entire IPv4 stack to keep the IP packet header
2012-10-22 21:09:03 +00:00
ip6.h
Use IP6STAT_INC/IP6STAT_DEC macros to update ip6 stats.
2013-04-09 07:11:22 +00:00
ip_carp.c
Use m_get/m_gethdr instead of compat macros.
2013-03-15 12:55:30 +00:00
ip_carp.h
Resolve source address selection in presense of CARP. Add a couple
2013-02-11 10:58:22 +00:00
ip_divert.c
Switch the entire IPv4 stack to keep the IP packet header
2012-10-22 21:09:03 +00:00
ip_divert.h
…
ip_dummynet.h
s/lenght/length/ in comments
2012-08-07 07:52:25 +00:00
ip_ecn.c
…
ip_ecn.h
…
ip_encap.c
…
ip_encap.h
…
ip_fastfwd.c
Remove the recently added sysctl variable net.pfil.forward.
2012-11-02 01:20:55 +00:00
ip_fw.h
Add ipfw support for setting/matching DiffServ codepoints (DSCP).
2013-03-20 10:35:33 +00:00
ip_gre.c
Switch the entire IPv4 stack to keep the IP packet header
2012-10-22 21:09:03 +00:00
ip_gre.h
…
ip_icmp.c
Mechanically substitute flags from historic mbuf allocator with
2012-12-05 08:04:20 +00:00
ip_icmp.h
…
ip_id.c
Change certain heavily used network related mutexes and rwlocks to
2013-04-09 21:02:20 +00:00
ip_input.c
Change certain heavily used network related mutexes and rwlocks to
2013-04-09 21:02:20 +00:00
ip_ipsec.c
Switch the entire IPv4 stack to keep the IP packet header
2012-10-22 21:09:03 +00:00
ip_ipsec.h
…
ip_mroute.c
Use m_get/m_gethdr instead of compat macros.
2013-03-15 12:55:30 +00:00
ip_mroute.h
Remove route caching from IP multicast routing code. There is no
2012-07-02 19:44:18 +00:00
ip_options.c
- Replace compat macros with function calls.
2013-03-16 08:58:28 +00:00
ip_options.h
In ip_stripoptions():
2012-10-12 09:24:24 +00:00
ip_output.c
Use m_get/m_gethdr instead of compat macros.
2013-03-15 12:55:30 +00:00
ip_var.h
Merge from projects/counters: TCP/IP stats.
2013-04-08 19:57:21 +00:00
ip.h
Add ToS definitions for DiffServ Codepoints as per RFC2474.
2012-05-04 21:00:32 +00:00
pim_var.h
…
pim.h
…
raw_ip.c
Mechanically substitute flags from historic mbuf allocator with
2012-12-05 08:04:20 +00:00
sctp_asconf.c
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctp_asconf.h
Pass the src and dst address of a received packet explicitly around.
2012-06-28 16:01:08 +00:00
sctp_auth.c
Mechanically substitute flags from historic mbuf allocator with
2012-12-05 08:04:20 +00:00
sctp_auth.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_bsd_addr.c
Testing an interface property should depend on the interface, not
2012-08-04 08:03:30 +00:00
sctp_bsd_addr.h
Do packet logging in a consistent way.
2012-06-24 21:25:54 +00:00
sctp_cc_functions.c
Get rid of a gcc'ism.
2012-09-06 07:03:56 +00:00
sctp_constants.h
Add a macro for checking for IPv4 link local addresses.
2013-03-31 18:27:46 +00:00
sctp_crc32.c
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_crc32.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_dtrace_declare.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_dtrace_define.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_header.h
Don't include a structure containing a flexible array in another
2012-09-07 13:36:42 +00:00
sctp_indata.c
Don't send kernel provided information in the User Initiated
2013-02-11 13:57:03 +00:00
sctp_indata.h
Pass the src and dst address of a received packet explicitly around.
2012-06-28 16:01:08 +00:00
sctp_input.c
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctp_input.h
Don't include a structure containing a flexible array in another
2012-09-07 13:36:42 +00:00
sctp_lock_bsd.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_os_bsd.h
Pass the src and dst address of a received packet explicitly around.
2012-06-28 16:01:08 +00:00
sctp_os.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_output.c
Send the adaptation layer indication only if set by the user.
2013-02-11 21:02:49 +00:00
sctp_output.h
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctp_pcb.c
Send the adaptation layer indication only if set by the user.
2013-02-11 21:02:49 +00:00
sctp_pcb.h
Send the adaptation layer indication only if set by the user.
2013-02-11 21:02:49 +00:00
sctp_peeloff.c
Add support for sctp_peeloff() also in the front states of the
2012-11-26 16:44:03 +00:00
sctp_peeloff.h
Remove unused function.
2012-11-25 14:25:08 +00:00
sctp_ss_functions.c
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_structs.h
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctp_sysctl.c
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctp_sysctl.h
Whitespace cleanup.
2012-06-25 17:15:09 +00:00
sctp_timer.c
Fix a bug where HEARTBEATs were still sent in SHUTDOWN_SENT or
2013-02-09 08:27:08 +00:00
sctp_timer.h
Use consistent text at the begining of the files.
2012-05-23 11:26:28 +00:00
sctp_uio.h
Whitespace changes due to upstream integration of SCTP changes in the
2012-10-29 20:47:32 +00:00
sctp_usrreq.c
Send the adaptation layer indication only if set by the user.
2013-02-11 21:02:49 +00:00
sctp_var.h
Whitespace changes due to upstream integration of SCTP changes in the
2012-10-29 20:47:32 +00:00
sctp.h
Cleanup the handling of address scopes. Announce in the INIT/INIT-ACK
2013-02-09 17:26:14 +00:00
sctputil.c
Fix a potential race in returning setting errno when an
2013-02-27 19:51:47 +00:00
sctputil.h
Add support for SCTP/UDP/IPV6.
2012-11-17 20:04:04 +00:00
siftr.c
The hashmask returned by hashinit() is a valid index in the returned hash array.
2013-03-07 04:42:20 +00:00
tcp_debug.c
Switch the entire IPv4 stack to keep the IP packet header
2012-10-22 21:09:03 +00:00
tcp_debug.h
…
tcp_fsm.h
…
tcp_hostcache.c
- Update cachelimit after hashsize and bucketlimit were set.
2012-10-19 14:00:03 +00:00
tcp_hostcache.h
…
tcp_input.c
Fix a race condition on tcp listen socket teardown with pending
2013-04-09 20:52:26 +00:00
tcp_lro.c
Fix tcp_lro_rx_ipv4() for drivers that do not set CSUM_IP_CHECKED.
2013-02-21 17:00:35 +00:00
tcp_lro.h
MFp4 bz_ipv6_fast:
2012-05-24 23:03:23 +00:00
tcp_offload.c
- Updated TOE support in the kernel.
2012-06-19 07:34:13 +00:00
tcp_offload.h
- Updated TOE support in the kernel.
2012-06-19 07:34:13 +00:00
tcp_output.c
Fix tcp_output() so that tcpcb is updated in the same manner when an
2013-04-11 18:23:56 +00:00
tcp_reass.c
uma_zone_set_max() directly returns the rounded effective zone
2013-02-01 14:21:09 +00:00
tcp_sack.c
Covers values if (BYTES_THIS_ACK(tp, th) / tp->t_maxseg) value is from
2011-03-28 19:03:56 +00:00
tcp_seq.h
Fix PAWS (Protect Against Wrapped Sequence numbers) in cases when
2012-02-15 16:09:56 +00:00
tcp_subr.c
Change certain heavily used network related mutexes and rwlocks to
2013-04-09 21:02:20 +00:00
tcp_syncache.c
uma_zone_set_max() directly returns the rounded effective zone
2013-02-01 14:21:09 +00:00
tcp_syncache.h
Change the syncache count reporting the current number of entries
2012-10-28 18:07:34 +00:00
tcp_timer.c
- Make callout(9) tickless, relying on eventtimers(4) as backend for
2013-03-04 11:09:56 +00:00
tcp_timer.h
Add DELACK to list of timers.
2012-11-27 19:07:28 +00:00
tcp_timewait.c
Mechanically substitute flags from historic mbuf allocator with
2012-12-05 08:04:20 +00:00
tcp_usrreq.c
Add checks for SO_NO_OFFLOAD in a couple of places that I missed earlier
2013-01-26 01:41:42 +00:00
tcp_var.h
Merge from projects/counters: TCP/IP stats.
2013-04-08 19:57:21 +00:00
tcp.h
Add placeholder constants to reserve a portion of the socket option
2013-02-01 15:32:20 +00:00
tcpip.h
…
toecore.c
Teach toe_l2_resolve to resolve IPv6 destinations too.
2013-01-26 00:57:29 +00:00
toecore.h
Correctly handle the case where an inp has already been dropped by the time
2012-08-21 18:09:33 +00:00
udp_usrreq.c
More warnings for zones that depend on the kern.ipc.maxsockets limit.
2012-12-08 12:51:06 +00:00
udp_var.h
Export the udp_cksum sysctl for upcoming SCTP work. Rather than always,
2012-03-27 15:14:29 +00:00
udp.h
Add placeholder constants to reserve a portion of the socket option
2013-02-01 15:32:20 +00:00