freebsd with flexible iflib nic queues
Go to file
Andriy Gapon 930f1af491 MFC r316912: 7793 ztest fails assertion in dmu_tx_willuse_space
illumos/illumos-gate@61e255ce72
61e255ce72

https://www.illumos.org/issues/7793
  Background information: This assertion about tx_space_* verifies that we
  are not dirtying more stuff than we thought we would. We “need” to know
  how much we will dirty so that we can check if we should fail this
  transaction with ENOSPC/EDQUOT, in dmu_tx_assign(). While the
  transaction is open (i.e. between dmu_tx_assign() and dmu_tx_commit() —
  typically less than a millisecond), we call dbuf_dirty() on the exact
  blocks that will be modified. Once this happens, the temporary
  accounting in tx_space_* is unnecessary, because we know exactly what
  blocks are newly dirtied; we call dnode_willuse_space() to track this
  more exact accounting.
  The fundamental problem causing this bug is that dmu_tx_hold_*() relies
  on the current state in the DMU (e.g. dn_nlevels) to predict how much
  will be dirtied by this transaction, but this state can change before we
  actually perform the transaction (i.e. call dbuf_dirty()).
  This bug will be fixed by removing the assertion that the tx_space_*
  accounting is perfectly accurate (i.e. we never dirty more than was
  predicted by dmu_tx_hold_*()). By removing the requirement that this
  accounting be perfectly accurate, we can also vastly simplify it, e.g.
  removing most of the logic in dmu_tx_count_*().
  The new tx space accounting will be very approximate, and may be more or
  less than what is actually dirtied. It will still be used to determine
  if this transaction will put us over quota. Transactions that are marked
  by dmu_tx_mark_netfree() will be excepted from this check. We won’t make
  an attempt to determine how much space will be freed by the transaction
  — this was rarely accurate enough to determine if a transaction should
  be permitted when we are over quota, which is why dmu_tx_mark_netfree()
  was introduced in 2014.
  We also won’t attempt to give “credit” when overwriting existing blocks,
  if those blocks may be freed. This allows us to remove the
  do_free_accounting logic in dbuf_dirty(), and associated routines. This

Reviewed by: Steve Gonczi <steve.gonczi@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Robert Mustacchi <rm@joyent.com>
Author: Matthew Ahrens <mahrens@delphix.com>
MFC after:	3 weeks
2017-05-24 21:43:34 +00:00
bin sh: Keep output buffer across builtins. 2017-05-18 22:10:04 +00:00
cddl MFC r316908: 7541 zpool import/tryimport ioctl returns ENOMEM because provided buffer is too small for config 2017-05-24 21:32:35 +00:00
contrib Extend libblacklist support with new action types 2017-05-23 19:03:07 +00:00
crypto Refine and update blacklist support in sshd 2017-05-12 15:20:12 +00:00
etc compress: Add basic tests. 2017-05-21 14:05:32 +00:00
gnu Add 11.1 to the mdoc(7) mdoc.local.in. 2017-05-22 14:21:07 +00:00
include Use __BSD_VISIBLE test instead checking for absense of _POSIX_SOURCE. 2017-05-24 09:25:13 +00:00
kerberos5 kerberos5: normalize paths using SRCTOP-relative paths or :H when possible 2017-03-04 11:34:36 +00:00
lib Don't end up manpage titles with a full stop. 2017-05-24 21:02:53 +00:00
libexec For ld.so direct execution mode, implement -p option: search for the 2017-05-23 10:00:52 +00:00
release Allow PORTSDIR to be overridden in the pkg-stage target. 2017-05-22 14:21:45 +00:00
rescue DIRDEPS_BUILD: Update dependencies. 2017-05-09 01:48:23 +00:00
sbin Update the "first appeared in" version in several manual pages. 2017-05-24 17:47:49 +00:00
secure Fix invalid .o SRCS from r314527. 2017-05-09 01:48:02 +00:00
share Don't end up manpage titles with a full stop. 2017-05-24 21:02:53 +00:00
sys MFC r316912: 7793 ztest fails assertion in dmu_tx_willuse_space 2017-05-24 21:43:34 +00:00
targets Enable llvm-objdump by default per r310775 2017-05-16 03:12:51 +00:00
tests Fix build of AIO tests with -DDEBUG 2017-05-21 15:37:08 +00:00
tools Honor WITHOUT_TFTP for check-old* and delete-old* targets. 2017-05-23 15:46:21 +00:00
usr.bin Commit the 64-bit inode project. 2017-05-23 09:29:05 +00:00
usr.sbin Don't end up manpage titles with a full stop. 2017-05-24 21:02:53 +00:00
.arcconfig
.arclint
COPYRIGHT Bump copyright year. 2016-12-31 12:41:42 +00:00
LOCKS
MAINTAINERS Due to time constraints remove myself as a vmm(4) maintainer. 2017-04-15 22:42:23 +00:00
Makefile Cache compiler metadata and reuse it at installworld time. 2017-04-13 22:07:34 +00:00
Makefile.inc1 Add a -DNO_LIBS to skip building the libraries phase as well. 2017-05-09 23:58:07 +00:00
Makefile.libcompat Support skipping 'make obj' tree-walk. 2017-05-09 20:21:38 +00:00
ObsoleteFiles.inc Revert r317446 and bring back cy(4). 2017-04-27 16:14:32 +00:00
README Correct the URL to instructions for updated system sources. 2017-05-15 15:18:36 +00:00
README.md Remove hard line breaks from README.md 2017-03-01 15:39:58 +00:00
UPDATING UPDATING: clarify ino64 upgrade instructions even further 2017-05-24 17:11:10 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html