George Amanakis 9ffcaa370a
Avoid deadlock when removing L2ARC devices under I/O
In case we have I/O and try to remove an L2ARC device a deadlock might
occur. arc_read()->zio_read()->zfs_blkptr_verify() waits for SCL_VDEV
to be dropped while holding the hash_lock. However, spa_l2cache_load()
holds SCL_ALL and waits for the hash_lock in l2arc_evict().

Fix this by moving zfs_blkptr_verify() to the top top arc_read() before
the hash_lock is taken. Verify the block pointer and return a checksum
error if damaged rather than halting the system, by using
BLK_VERIFY_LOG instead of BLK_VERIFY_HALT.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #12054
2021-06-16 18:17:42 -06:00
..
2021-04-02 18:52:15 -07:00
2021-06-07 09:02:47 -07:00
2020-08-20 10:30:06 -07:00
2019-07-26 10:54:14 -07:00
2020-07-29 16:35:33 -07:00
2020-07-29 16:35:33 -07:00
2019-06-19 09:48:12 -07:00
2020-08-17 15:25:37 -07:00
2021-05-27 14:27:29 -06:00
2021-06-10 10:42:31 -06:00
2020-06-18 12:21:18 -07:00
2019-12-03 09:51:44 -08:00
2020-11-02 11:51:12 -08:00
2021-06-10 10:42:31 -06:00
2020-11-10 10:37:10 -08:00
2021-06-10 10:42:31 -06:00
2021-04-02 18:52:15 -07:00
2021-06-10 10:42:31 -06:00
2021-06-10 10:42:31 -06:00
2020-09-04 10:29:39 -07:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:25 -07:00
2017-10-11 16:54:48 -04:00
2020-06-18 12:21:25 -07:00
2020-11-13 13:51:51 -08:00
2021-06-10 10:42:31 -06:00
2020-11-13 13:51:51 -08:00
2021-06-10 10:42:31 -06:00
2019-06-19 09:48:12 -07:00
2020-07-29 16:35:33 -07:00
2021-01-20 21:27:30 -08:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:25 -07:00
2021-02-20 20:16:50 -08:00
2019-09-02 17:56:41 -07:00
2021-06-10 08:27:33 -07:00
2019-10-09 10:36:03 -07:00
2021-01-26 19:36:51 -08:00
2021-06-10 08:27:33 -07:00
2020-11-13 13:51:51 -08:00
2020-07-29 16:35:33 -07:00
2020-06-18 12:21:25 -07:00
2019-09-02 17:56:41 -07:00
2020-10-02 17:44:10 -07:00
2020-06-18 12:20:38 -07:00
2021-01-20 21:27:30 -08:00
2020-06-18 12:20:38 -07:00
2020-11-13 13:51:51 -08:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:18 -07:00
2020-09-03 20:09:52 -07:00