Colin Percival 33812c066d If sufficiently bad things happen during a call to kern_execve(), it is ...

possible for do_execve() to call exit1() rather than returning.  As a
result, the sequence "allocate memory; call kern_execve; free memory"
can end up leaking memory.

This commit documents this astonishing behaviour and adds a call to
exec_free_args() before the exit1() call in do_execve().  Since all
the users of kern_execve() in the tree use exec_free_args() to free
the command-line arguments after kern_execve() returns, this should
be safe, and it fixes the memory leak which can otherwise occur.

Submitted by:	Peter Holm
MFC after:	3 days
Security:	Local denial of service

2005-10-03 12:49:54 +00:00

..

bus_if.m

…

clock_if.m

…

cpufreq_if.m

…

device_if.m

…

genassym.sh

…

imgact_aout.c

…

imgact_elf32.c

…

imgact_elf64.c

…

imgact_elf.c

Back out alpha/alpha/trap.c:1.124, osf1_ioctl.c:1.14, osf1_misc.c:1.57,

2005-09-28 07:03:03 +00:00

imgact_gzip.c

…

imgact_shell.c

…

inflate.c

…

init_main.c

Remove mac_create_root_mount() and mpo_create_root_mount(), which

2005-09-19 13:59:57 +00:00

init_sysent.c

Update the "created from" section to reflect the most recent version of

2005-09-27 14:36:59 +00:00

kern_acct.c

Pass 'curthread' into VFS_STATFS() from acctwatch(), rather than passing

2005-09-21 15:28:07 +00:00

kern_acl.c

Implement new world order in VFS locking for ACLs. This will remove the

2005-09-17 22:01:14 +00:00

kern_alq.c

…

kern_clock.c

…

kern_condvar.c

…

kern_conf.c

Make sure the clone lists are sorted in the right order.

2005-10-01 19:21:03 +00:00

kern_context.c

…

kern_cpu.c

make saved cpu level stackable.

2005-10-03 06:57:29 +00:00

kern_descrip.c

Two minor optimizations of fdalloc():

2005-08-26 11:16:39 +00:00

kern_environment.c

Reorder statements to avoid accessing unknown memory.

2005-09-26 14:14:55 +00:00

kern_event.c

Fix race condition that caused activation of an event to

2005-09-15 21:10:12 +00:00

kern_exec.c

If sufficiently bad things happen during a call to kern_execve(), it is

2005-10-03 12:49:54 +00:00

kern_exit.c

Add witness warnings to panic if a thread tries to exit while holding any

2005-09-02 20:20:01 +00:00

kern_fork.c

…

kern_idle.c

…

kern_intr.c

Don't disallow sleeping for handlers on swi's since some swi handlers

2005-09-15 20:08:21 +00:00

kern_jail.c

Push Giant down in jails. Pass the MPSAFE flag to NDINIT, and keep track

2005-09-28 00:30:56 +00:00

kern_kse.c

Fox a LOR of sleep and sched_lock by using a timeout wait

2005-09-30 06:09:41 +00:00

kern_kthread.c

…

kern_ktr.c

…

kern_ktrace.c

…

kern_linker.c

…

kern_lock.c

Include kdb.h so that kdb_active is declared regardless of KDB being

2005-10-02 10:03:51 +00:00

kern_lockf.c

…

kern_mac.c

…

kern_malloc.c

Long overdue, keep up with mbuf.h,v 1.148.

2005-08-02 20:03:23 +00:00

kern_mbuf.c

No longer maintain mbstat statistics for the mbuf allocator, UMA

2005-09-27 20:28:43 +00:00

kern_mib.c

mp_ncpus is always (properly) initialized, even on UP kernels, so just use it.

2005-08-21 18:03:31 +00:00

kern_module.c

…

kern_mtxpool.c

…

kern_mutex.c

- Add an assertion to panic if one tries to call mtx_trylock() on a spin

2005-09-02 20:21:49 +00:00

kern_ntptime.c

…

kern_physio.c

…

kern_pmc.c

Fail the module loading process if the currently executing kernel

2005-07-30 09:02:42 +00:00

kern_poll.c

Big polling(4) cleanup.

2005-10-01 18:56:19 +00:00

kern_proc.c

Always wire the sysctl output buffer in sysctl_kern_proc() before

2005-10-02 23:27:56 +00:00

kern_prot.c

Use the refcount API to manage the reference count for user credentials

2005-09-27 18:09:42 +00:00

kern_resource.c

Use the reference count API to manage the reference counts for process

2005-09-27 18:07:05 +00:00

kern_sema.c

…

kern_shutdown.c

Don't pretend to be thread0 when calling sync().

2005-09-22 15:34:15 +00:00

kern_sig.c

…

kern_subr.c

…

kern_switch.c

In adjustrunqueue(), add code to handle thread migrating case for

2005-08-03 01:23:45 +00:00

kern_sx.c

…

kern_synch.c

…

kern_syscalls.c

…

kern_sysctl.c

Drop in a WITNESS_WARN into SYSCTL_IN to make sure that we are

2005-08-08 21:06:42 +00:00

kern_tc.c

Start time_uptime with 1 instead of 0.

2005-09-19 22:16:31 +00:00

kern_thr.c

…

kern_thread.c

Fox a LOR of sleep and sched_lock by using a timeout wait

2005-09-30 06:09:41 +00:00

kern_time.c

…

kern_timeout.c

Oops, missed adding the required include.

2005-09-15 20:20:36 +00:00

kern_umtx.c

…

kern_uuid.c

Move the UUID generator into its own function, called kern_uuidgen(),

2005-09-18 21:40:15 +00:00

kern_xxx.c

…

ksched.c

…

link_elf_obj.c

Handle vm_map_wire()'s failure.

2005-08-28 05:38:40 +00:00

link_elf.c

Correctly handle vm_map_wire()'s failure. (See also revisions 1.81 and

2005-08-28 04:50:11 +00:00

linker_if.m

…

Make.tags.inc

…

Makefile

…

makesyscalls.sh

…

md4c.c

…

md5c.c

…

p1003_1b.c

…

posix4_mib.c

…

sched_4bsd.c

…

sched_ule.c

Temporarily disable nice threshold detection code, as it can starve

2005-09-22 01:19:37 +00:00

subr_acl_posix1e.c

Implement new world order in VFS locking for ACLs. This will remove the

2005-09-17 22:01:14 +00:00

subr_autoconf.c

…

subr_blist.c

…

subr_bus.c

Add two convenience functions for device drivers: bus_alloc_resources()

2005-09-24 19:31:10 +00:00

subr_clist.c

…

subr_clock.c

…

subr_devstat.c

…

subr_disk.c

…

subr_eventhandler.c

…

subr_hints.c

The resource_xxx routines in subr_hints.c are called before and after the

2005-07-31 10:46:55 +00:00

subr_kdb.c

If KDB_STOP_NMI is compiled into the kernel, default

2005-09-27 21:12:05 +00:00

subr_kobj.c

Export a routine, kobj_machdep_init(), that allows platforms

2005-08-07 02:20:35 +00:00

subr_log.c

…

subr_mbpool.c

…

subr_mchain.c

Change API of mb_copy_t in libmchain so that netsmb can handle

2005-07-29 13:22:37 +00:00

subr_module.c

…

subr_msgbuf.c

…

subr_param.c

…

subr_pcpu.c

Add "show allpcpu" to DDB, which prints the current CPU id followed by

2005-09-26 16:55:11 +00:00

subr_power.c

…

subr_prf.c

Acquire Giant in uprintf() and tprintf() rather than asserting it. In

2005-09-26 08:02:24 +00:00

subr_prof.c

…

subr_rman.c

puc(4) does strange things to resources in order to fool the

2005-09-28 18:06:25 +00:00

subr_rtc.c

…

subr_sbuf.c

…

subr_scanf.c

…

subr_sleepqueue.c

- Add a new simple facility for marking the current thread as being in a

2005-09-15 19:05:37 +00:00

subr_smp.c

…

subr_stack.c

Add 'depth' argument to CTRSTACK() macro, which allows to reduce number

2005-08-29 11:34:08 +00:00

subr_taskqueue.c

…

subr_trap.c

…

subr_turnstile.c

Trim a couple of unneeded includes.

2005-09-29 19:13:52 +00:00

subr_unit.c

…

subr_witness.c

Add the spin lock used by the binary nvidia driver to the static lock

2005-09-26 18:30:12 +00:00

sys_generic.c

…

sys_pipe.c

…

sys_process.c

Fix a LOR between sched_lock and sleep queue lock.

2005-08-19 13:35:34 +00:00

sys_socket.c

…

syscalls.c

Update the "created from" section to reflect the most recent version of

2005-09-27 14:36:59 +00:00

syscalls.master

Mark the extended attribute syscalls as being MP safe.

2005-09-27 14:32:04 +00:00

sysv_ipc.c

…

sysv_msg.c

…

sysv_sem.c

…

sysv_shm.c

Change the data type of the upper shared memory limits from a signed

2005-08-06 07:20:18 +00:00

tty_compat.c

…

tty_conf.c

…

tty_cons.c

…

tty_pty.c

Merge the dev_clone and dev_clone_cred event handlers into a single

2005-08-08 19:55:32 +00:00

tty_subr.c

…

tty_tty.c

Merge the dev_clone and dev_clone_cred event handlers into a single

2005-08-08 19:55:32 +00:00

tty.c

…

uipc_accf.c

…

uipc_cow.c

…

uipc_domain.c

…

uipc_mbuf2.c

…

uipc_mbuf.c

Changes and cleanups to m_sanity():

2005-08-30 21:31:42 +00:00

uipc_proto.c

…

uipc_sem.c

…

uipc_sockbuf.c

Re-comment sbcompress() to explain what it is it does; it took me

2005-09-18 10:30:10 +00:00

uipc_socket2.c

Re-comment sbcompress() to explain what it is it does; it took me

2005-09-18 10:30:10 +00:00

uipc_socket.c

Add three new read-only socket options, which allow regression tests

2005-09-18 21:08:03 +00:00

uipc_syscalls.c

…

uipc_usrreq.c

Canonicalize the UNIX domain socket copyright layout: original holders

2005-09-23 12:41:06 +00:00

vfs_acl.c

Implement new world order in VFS locking for ACLs. This will remove the

2005-09-17 22:01:14 +00:00

vfs_aio.c

…

vfs_bio.c

Un-staticize waitrunningbufspace() and call it before returning from

2005-09-30 18:07:41 +00:00

vfs_cache.c

…

vfs_cluster.c

Do not use vm_pager_init() to initialize vnode_pbuf_freecnt variable.

2005-08-13 20:21:33 +00:00

vfs_default.c

In vop_stdpathconf(ap) also default for _PC_NAME_MAX and _PC_PATH_MAX.

2005-08-17 06:59:23 +00:00

vfs_export.c

Use the refcount API to manage the reference count for user credentials

2005-09-27 18:09:42 +00:00

vfs_extattr.c

Implement new world order in VFS locking for extended attributes. This will

2005-09-24 23:47:04 +00:00

vfs_hash.c

Don't retry when vget() returns ENOENT in the nonblocking case due to the

2005-09-12 01:48:57 +00:00

vfs_init.c

…

vfs_lookup.c

Use correct VFS locking rather than unconditionally grabbing Giant around

2005-09-21 19:49:42 +00:00

vfs_mount.c

Don't unbusy the devfs mount in vfs_mountroot_try() as it gets accessed

2005-09-02 13:37:54 +00:00

vfs_subr.c

Un-staticize runningbufwakeup() and staticize updateproc.

2005-09-30 01:30:01 +00:00

vfs_syscalls.c

Implement new world order in VFS locking for extended attributes. This will

2005-09-24 23:47:04 +00:00

vfs_vnops.c

- Replace the series of DEBUG_LOCKS hacks which tried to save the vn_lock

2005-08-03 04:48:22 +00:00

vnode_if.src

…