freebsd-nq/sys/boot/common/ls.c
Toomas Soome 5b6123e31d loader is filling fixed length command_errbuf with sprintf() and is trusting
strings provided by user/config files. This update is replacing sprintf with
snprintf for cases the command_errbuf is built from dynamic content.

PR:		211958
Reported by:	ecturt@gmail.com
Reviewed by:	imp, allanjude
Approved by:	imp (mentor), allanjude (mentor)
Differential Revision:	https://reviews.freebsd.org/D7563
2016-08-20 16:23:19 +00:00

189 lines
4.9 KiB
C

/*
* $NetBSD: ls.c,v 1.3 1997/06/13 13:48:47 drochner Exp $
*/
/*-
* Copyright (c) 1993
* The Regents of the University of California. All rights reserved.
* Copyright (c) 1996
* Matthias Drochner. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. All advertising materials mentioning features or use of this software
* must display the following acknowledgement:
* This product includes software developed by the University of
* California, Berkeley and its contributors.
* 4. Neither the name of the University nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <ufs/ufs/dinode.h>
#include <ufs/ufs/dir.h>
#include <stand.h>
#include <string.h>
#include "bootstrap.h"
static char typestr[] = "?fc?d?b? ?l?s?w";
static int ls_getdir(char **pathp);
COMMAND_SET(ls, "ls", "list files", command_ls);
static int
command_ls(int argc, char *argv[])
{
int fd;
struct stat sb;
struct dirent *d;
char *buf, *path;
char lbuf[128]; /* one line */
int result, ch;
int verbose;
result = CMD_OK;
fd = -1;
verbose = 0;
optind = 1;
optreset = 1;
while ((ch = getopt(argc, argv, "l")) != -1) {
switch(ch) {
case 'l':
verbose = 1;
break;
case '?':
default:
/* getopt has already reported an error */
return(CMD_OK);
}
}
argv += (optind - 1);
argc -= (optind - 1);
if (argc < 2) {
path = "";
} else {
path = argv[1];
}
fd = ls_getdir(&path);
if (fd == -1) {
result = CMD_ERROR;
goto out;
}
pager_open();
pager_output(path);
pager_output("\n");
while ((d = readdirfd(fd)) != NULL) {
if (strcmp(d->d_name, ".") && strcmp(d->d_name, "..")) {
if (verbose) {
/* stat the file, if possible */
sb.st_size = 0;
buf = malloc(strlen(path) + strlen(d->d_name) + 2);
sprintf(buf, "%s/%s", path, d->d_name);
/* ignore return, could be symlink, etc. */
if (stat(buf, &sb))
sb.st_size = 0;
free(buf);
sprintf(lbuf, " %c %8d %s\n", typestr[d->d_type],
(int)sb.st_size, d->d_name);
} else {
sprintf(lbuf, " %c %s\n", typestr[d->d_type], d->d_name);
}
if (pager_output(lbuf))
goto out;
}
}
out:
pager_close();
if (fd != -1)
close(fd);
if (path != NULL)
free(path);
return(result);
}
/*
* Given (path) containing a vaguely reasonable path specification, return an fd
* on the directory, and an allocated copy of the path to the directory.
*/
static int
ls_getdir(char **pathp)
{
struct stat sb;
int fd;
const char *cp;
char *path, *tail;
tail = NULL;
fd = -1;
/* one extra byte for a possible trailing slash required */
path = malloc(strlen(*pathp) + 2);
strcpy(path, *pathp);
/* Make sure the path is respectable to begin with */
if (archsw.arch_getdev(NULL, path, &cp)) {
snprintf(command_errbuf, sizeof(command_errbuf),
"bad path '%s'", path);
goto out;
}
/* If there's no path on the device, assume '/' */
if (*cp == 0)
strcat(path, "/");
fd = open(path, O_RDONLY);
if (fd < 0) {
snprintf(command_errbuf, sizeof(command_errbuf),
"open '%s' failed: %s", path, strerror(errno));
goto out;
}
if (fstat(fd, &sb) < 0) {
snprintf(command_errbuf, sizeof(command_errbuf),
"stat failed: %s", strerror(errno));
goto out;
}
if (!S_ISDIR(sb.st_mode)) {
snprintf(command_errbuf, sizeof(command_errbuf),
"%s: %s", path, strerror(ENOTDIR));
goto out;
}
*pathp = path;
return(fd);
out:
free(path);
*pathp = NULL;
if (fd != -1)
close(fd);
return(-1);
}