4df0520624
Quick fix for calling DELAY() for ddb input in some (atkbd-based) console drivers. ddb must not use any normal locks, but DELAY() normally calls getit() which needs clock_lock. One problem with using normal locks in ddb is that deadlock is possible, but deadlock on clock_lock is unlikely becaluse clock_lock is bogusly recursive, apparently just to hide the problem of ddb using it. The i8254 clock hardware has mostly write-only registers so it is important for it to use a lock that gives exclusive access. (atkbd hardware is also unfriendly to reentrant software but that problem is more local and already solved.) I mostly saw the symptoms of the bug caused by unlocking in getit() running cpu_unpend(). cpu_unpend() should not be called while in ddb and Debugger() calls for failing assertions about this caused a breakpoint within ddb. ddb must also not call getit() because ddb may be being used to step through clock initialization code that has stopped or otherwise mangled the clock. If the clock is stopped, then getit() always returns the same value and DELAY() takes forever if it trusts getit(). The quick fix is implement DELAY(n) as (n * timer_freq / 1000000) inb(0x84)'s if ddb is active. machdep.c: Don't permit recursion on clock_lock. |
||
|---|---|---|
| .. | ||
| atkbd_isa.c | ||
| atkbdc_isa.c | ||
| atrtc.c | ||
| fd.c | ||
| fdreg.h | ||
| isa_common.c | ||
| isa_common.h | ||
| isa_if.m | ||
| isahint.c | ||
| isareg.h | ||
| isavar.h | ||
| orm.c | ||
| pnp.c | ||
| pnpparse.c | ||
| pnpreg.h | ||
| pnpvar.h | ||
| psm.c | ||
| rtc.h | ||
| syscons_isa.c | ||
| vga_isa.c | ||