Eitan Adler f5ce166436 msun: signed overflow in atan2 ...

As a component of atan2(y, x), the case of x == 1.0 is farmed out to
atan(y). The current implementation of this comparison is vulnerable
to signed integer underflow (that is, undefined behavior), and it's
performed in a somewhat more complicated way than it need be. Change
it to not be quite so cute, rather directly comparing the high/low
bits of x to the specific IEEE-754 bit pattern that encodes 1.0.

Note that while there are three different e_atan* files in the
relevant directory, only this one needs fixing. e_atan2f.c already
compares against the full bit pattern encoding 1.0f, while
e_atan2l.cuses bitwise-ands/ors/nots and so doesn't require a change.

Closes #130

Submitted by:	Jeff Walden (@jswalden github PR #130)
Reviewed by:	bde
MFC After:	1 month

2018-02-14 07:59:30 +00:00

..

catrig.c

lib: Fix several typos and minor errors

2017-12-27 03:23:41 +00:00

catrigf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

catrigl.c

lib/msun: avoid referring to broken LDBL_MAX

2017-08-29 22:32:29 +00:00

e_acos.c

…

e_acosf.c

…

e_acosh.c

…

e_acoshf.c

…

e_acoshl.c

…

e_acosl.c

…

e_asin.c

msun: Remove trailing space in Sunsoft copyright statement.

2017-04-23 22:31:12 +00:00

e_asinf.c

…

e_asinl.c

…

e_atan2.c

msun: signed overflow in atan2

2018-02-14 07:59:30 +00:00

e_atan2f.c

…

e_atan2l.c

…

e_atanh.c

…

e_atanhf.c

…

e_atanhl.c

…

e_cosh.c

…

e_coshf.c

…

e_coshl.c

libm: remove unused variables for LDBL_MANT_DIG != 113

2016-09-30 20:20:07 +00:00

e_exp.c

…

e_expf.c

…

e_fmod.c

Fix missing fmodl() on arches with 53-bit long doubles.

2016-09-04 12:01:32 +00:00

e_fmodf.c

…

e_fmodl.c

…

e_gamma_r.c

…

e_gamma.c

…

e_gammaf_r.c

…

e_gammaf.c

…

e_hypot.c

…

e_hypotf.c

…

e_hypotl.c

…

e_j0.c

In r279493, the functions pzero[f](), qzero[f], pone[f](),

2015-05-17 16:27:06 +00:00

e_j0f.c

In r279493, the functions pzero[f](), qzero[f], pone[f](),

2015-05-17 16:27:06 +00:00

e_j1.c

In r279493, the functions pzero[f](), qzero[f], pone[f](),

2015-05-17 16:27:06 +00:00

e_j1f.c

In r279493, the functions pzero[f](), qzero[f], pone[f](),

2015-05-17 16:27:06 +00:00

e_jn.c

According to POSIX.1-2008, the Bessel functions of second kind

2015-03-10 17:10:54 +00:00

e_jnf.c

According to POSIX.1-2008, the Bessel functions of second kind

2015-03-10 17:10:54 +00:00

e_lgamma_r.c

…

e_lgamma.c

…

e_lgammaf_r.c

libm: remove unused variables

2016-10-05 17:04:58 +00:00

e_lgammaf.c

…

e_lgammal.c

…

e_log2.c

…

e_log2f.c

…

e_log10.c

…

e_log10f.c

…

e_log.c

…

e_logf.c

…

e_pow.c

lib/msun: remove trailing whitespace from e_pow.c

2017-12-03 01:56:03 +00:00

e_powf.c

…

e_rem_pio2.c

…

e_rem_pio2f.c

…

e_remainder.c

…

e_remainderf.c

…

e_remainderl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

e_scalb.c

…

e_scalbf.c

…

e_sinh.c

…

e_sinhf.c

…

e_sinhl.c

libm: remove unused variables for LDBL_MANT_DIG != 113

2016-09-30 20:20:07 +00:00

e_sqrt.c

…

e_sqrtf.c

…

e_sqrtl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

fenv-softfloat.h

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

imprecise.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

k_cos.c

…

k_cosf.c

…

k_exp.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

k_expf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

k_log.h

…

k_logf.h

…

k_rem_pio2.c

lib: minor spelling fixes in comments.

2016-05-01 19:37:33 +00:00

k_sin.c

…

k_sincos.h

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

k_sincosf.h

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

k_sincosl.h

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

k_sinf.c

…

k_tan.c

…

k_tanf.c

…

math_private.h

Revert r322418, LDBL_MAX_EXP unsuitable for macro pasting on some arches

2017-08-12 18:28:02 +00:00

math.h

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

s_asinh.c

…

s_asinhf.c

…

s_asinhl.c

…

s_atan.c

…

s_atanf.c

…

s_atanl.c

…

s_carg.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cargf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cargl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cbrt.c

lib: minor spelling fixes in comments.

2016-05-01 19:37:33 +00:00

s_cbrtf.c

…

s_cbrtl.c

…

s_ccosh.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_ccoshf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_ceil.c

…

s_ceilf.c

…

s_ceill.c

…

s_cexp.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cexpf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cimag.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cimagf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cimagl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_conj.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_conjf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_conjl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_copysign.c

…

s_copysignf.c

…

s_copysignl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cos.c

…

s_cosf.c

…

s_cosl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cproj.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cprojf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_cprojl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_creal.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_crealf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_creall.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_csinh.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_csinhf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_csqrt.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_csqrtf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_csqrtl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_ctanh.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_ctanhf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_erf.c

…

s_erff.c

…

s_exp2.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_exp2f.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_expm1.c

…

s_expm1f.c

…

s_fabs.c

libm: fix some unused variable (rcsid) and dangling else warnings

2016-09-28 14:48:34 +00:00

s_fabsf.c

…

s_fabsl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fdim.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_finite.c

…

s_finitef.c

…

s_floor.c

…

s_floorf.c

…

s_floorl.c

…

s_fma.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmaf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmal.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmax.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmaxf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmaxl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fmin.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fminf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_fminl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_frexp.c

…

s_frexpf.c

…

s_frexpl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_ilogb.c

…

s_ilogbf.c

…

s_ilogbl.c

…

s_isfinite.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_isnan.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_isnormal.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_llrint.c

…

s_llrintf.c

…

s_llrintl.c

…

s_llround.c

…

s_llroundf.c

…

s_llroundl.c

…

s_log1p.c

…

s_log1pf.c

…

s_logb.c

…

s_logbf.c

…

s_logbl.c

libm: fix some unused variable (rcsid) and dangling else warnings

2016-09-28 14:48:34 +00:00

s_lrint.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_lrintf.c

…

s_lrintl.c

…

s_lround.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_lroundf.c

…

s_lroundl.c

…

s_modf.c

…

s_modff.c

…

s_modfl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_nan.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_nearbyint.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_nextafter.c

…

s_nextafterf.c

…

s_nextafterl.c

…

s_nexttoward.c

…

s_nexttowardf.c

…

s_remquo.c

…

s_remquof.c

…

s_remquol.c

…

s_rint.c

…

s_rintf.c

…

s_rintl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_round.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_roundf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_roundl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_scalbln.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_scalbn.c

libm: fix some unused variable (rcsid) and dangling else warnings

2016-09-28 14:48:34 +00:00

s_scalbnf.c

libm: fix some unused variable (rcsid) and dangling else warnings

2016-09-28 14:48:34 +00:00

s_scalbnl.c

libm: fix some unused variable (rcsid) and dangling else warnings

2016-09-28 14:48:34 +00:00

s_signbit.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_signgam.c

…

s_significand.c

…

s_significandf.c

…

s_sin.c

…

s_sincos.c

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

s_sincosf.c

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

s_sincosl.c

Implement sincos, sincosf, and sincosl.

2017-05-28 06:13:38 +00:00

s_sinf.c

…

s_sinl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_tan.c

…

s_tanf.c

…

s_tanh.c

…

s_tanhf.c

…

s_tanhl.c

libm: remove unused variables for LDBL_MANT_DIG != 113

2016-09-30 20:20:07 +00:00

s_tanl.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_tgammaf.c

lib: further adoption of SPDX licensing ID tags.

2017-11-26 02:00:33 +00:00

s_trunc.c

…

s_truncf.c

…

s_truncl.c

…

w_cabs.c

…

w_cabsf.c

…

w_cabsl.c

…

w_drem.c

…

w_dremf.c

…