10f81a9b3b
- kvm_close: add a testcase to verify support for errno = EINVAL / -1
(see D10065) when kd == NULL is provided to the libcall.
- kvm_geterr:
-- Add a negative testcase for kd == NULL returning "" (see D10022).
-- Add two positive testcases:
--- test the error case using kvm_write on a O_RDONLY descriptor.
--- test the "no error" case using kvm_read(3) and kvm_nlist(3) as
helper routines and by injecting a bogus error message via
_kvm_err (an internal API) _kvm_err was used as there isn't a
formalized way to clear the error output, and because
kvm_nlist always returns ENOENT with the NULL terminator today.
- kvm_open, kvm_open2:
-- Add some basic negative tests for kvm_open(3) and kvm_open2(3).
Testing positive cases with a specific
`corefile`/`execfile`/`resolver` requires more work and would require
user intervention today in order to reliably test this out.
Reviewed by: markj
MFC after: 2 months
Sponsored by: Dell EMC Isilon
Differential Revision: D10024
138 lines
4.2 KiB
C
138 lines
4.2 KiB
C
/*-
|
|
* Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#include <sys/param.h>
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <kvm.h>
|
|
#include <limits.h>
|
|
#include <signal.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <atf-c.h>
|
|
|
|
#include "kvm_private.h"
|
|
|
|
#include "kvm_test_common.h"
|
|
|
|
ATF_TC(kvm_geterr_negative_test_NULL);
|
|
ATF_TC_HEAD(kvm_geterr_negative_test_NULL, tc)
|
|
{
|
|
|
|
atf_tc_set_md_var(tc, "descr",
|
|
"test that kvm_geterr(NULL) returns NULL");
|
|
}
|
|
|
|
ATF_TC_BODY(kvm_geterr_negative_test_NULL, tc)
|
|
{
|
|
|
|
ATF_REQUIRE(!errbuf_has_error(kvm_geterr(NULL)));
|
|
}
|
|
|
|
ATF_TC(kvm_geterr_positive_test_error);
|
|
ATF_TC_HEAD(kvm_geterr_positive_test_error, tc)
|
|
{
|
|
|
|
atf_tc_set_md_var(tc, "descr",
|
|
"test that kvm_geterr(kd) when kd doesn't contain an error returns \"\"");
|
|
atf_tc_set_md_var(tc, "require.user", "root");
|
|
}
|
|
|
|
ATF_TC_BODY(kvm_geterr_positive_test_error, tc)
|
|
{
|
|
kvm_t *kd;
|
|
char *error_msg;
|
|
|
|
errbuf_clear();
|
|
kd = kvm_open2(NULL, NULL, O_RDONLY, errbuf, NULL);
|
|
ATF_CHECK(!errbuf_has_error(errbuf));
|
|
ATF_REQUIRE_MSG(kd != NULL, "kvm_open2 failed: %s", errbuf);
|
|
ATF_REQUIRE_MSG(kvm_write(kd, 0, NULL, 0) == -1,
|
|
"kvm_write succeeded unexpectedly on an O_RDONLY file descriptor");
|
|
error_msg = kvm_geterr(kd);
|
|
ATF_CHECK(errbuf_has_error(error_msg));
|
|
ATF_REQUIRE_MSG(kvm_close(kd) == 0, "kvm_close failed: %s",
|
|
strerror(errno));
|
|
}
|
|
|
|
ATF_TC(kvm_geterr_positive_test_no_error);
|
|
ATF_TC_HEAD(kvm_geterr_positive_test_no_error, tc)
|
|
{
|
|
|
|
atf_tc_set_md_var(tc, "descr",
|
|
"test that kvm_geterr(kd) when kd contains an error returns an error message");
|
|
atf_tc_set_md_var(tc, "require.user", "root");
|
|
}
|
|
|
|
ATF_TC_BODY(kvm_geterr_positive_test_no_error, tc)
|
|
{
|
|
#define ALL_IS_WELL "that ends well"
|
|
kvm_t *kd;
|
|
char *error_msg;
|
|
struct nlist nl[] = {
|
|
#define SYMNAME "_mp_maxcpus"
|
|
#define X_MAXCPUS 0
|
|
{ SYMNAME, 0, 0, 0, 0 },
|
|
{ NULL, 0, 0, 0, 0 },
|
|
};
|
|
ssize_t rc;
|
|
int mp_maxcpus, retcode;
|
|
|
|
errbuf_clear();
|
|
kd = kvm_open2(NULL, NULL, O_RDONLY, errbuf, NULL);
|
|
ATF_CHECK(!errbuf_has_error(errbuf));
|
|
ATF_REQUIRE_MSG(kd != NULL, "kvm_open2 failed: %s", errbuf);
|
|
retcode = kvm_nlist(kd, nl);
|
|
ATF_REQUIRE_MSG(retcode != -1,
|
|
"kvm_nlist failed (returned %d): %s", retcode, kvm_geterr(kd));
|
|
if (nl[X_MAXCPUS].n_type == 0)
|
|
atf_tc_skip("symbol (\"%s\") couldn't be found", SYMNAME);
|
|
_kvm_err(kd, NULL, "%s", ALL_IS_WELL); /* XXX: internal API */
|
|
rc = kvm_read(kd, nl[X_MAXCPUS].n_value, &mp_maxcpus,
|
|
sizeof(mp_maxcpus));
|
|
|
|
ATF_REQUIRE_MSG(rc != -1, "kvm_read failed: %s", kvm_geterr(kd));
|
|
error_msg = kvm_geterr(kd);
|
|
ATF_REQUIRE_MSG(strcmp(error_msg, ALL_IS_WELL) == 0,
|
|
"error message changed: %s", error_msg);
|
|
ATF_REQUIRE_MSG(kvm_close(kd) == 0, "kvm_close failed: %s",
|
|
strerror(errno));
|
|
}
|
|
|
|
ATF_TP_ADD_TCS(tp)
|
|
{
|
|
|
|
ATF_TP_ADD_TC(tp, kvm_geterr_negative_test_NULL);
|
|
ATF_TP_ADD_TC(tp, kvm_geterr_positive_test_error);
|
|
ATF_TP_ADD_TC(tp, kvm_geterr_positive_test_no_error);
|
|
|
|
return (atf_no_error());
|
|
}
|