Bryan Drewery
f222a6b886
dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value. ...
A test of this is funcs/tst.strtok.d which has this filter:
BEGIN
/(this->field = strtok(this->str, ",")) == NULL/
{
exit(1);
}
The test will randomly fail with exit status of 1 indicating that this->field
was NULL even though printing it out shows it is not.
This is compiled to the DTrace instruction set:
// Pushed arguments not shown here
// call strtok() and set result into %r1
07: 2f001f01 call DIF_SUBR(31), %r1 ! strtok
// set thread local scalar this->field from %r1
08: 39050101 stls %r1, DT_VAR(1281) ! DT_VAR(1281) = "field"
// Prepare for the == comparison
// Set right side of %r2 to NULL
09: 25000102 setx DT_INTEGER[1], %r2 ! 0x0
// string compare %r1 (strtok result) to %r2
10: 27010200 scmp %r1, %r2
In this case only %r1 is loaded with a string limit set to lim1. %r2 being
NULL does not get loaded and does not set lim2. Then we call dtrace_strncmp()
with MIN(lim1, lim2) resulting in passing 0 and comparing neither side.
dtrace_strncmp() handles this case fine and it already has been while
being lucky with what lim2 was [un]initialized as.
Reviewed by: markj, Don Morris <dgmorris AT earthlink.net>
Sponsored by: Dell EMC
Differential Revision: https://reviews.freebsd.org/D27671
2021-01-08 14:37:17 -08:00
2018-04-06 17:35:35 +00:00
2020-03-05 20:04:41 +00:00
2018-03-23 15:35:19 +00:00
2019-12-20 19:53:05 +00:00
2017-07-09 22:53:24 +00:00
2018-07-04 00:18:40 +00:00
2020-04-16 16:00:21 +00:00
2018-10-21 04:52:37 +00:00
2018-07-09 14:18:03 +00:00
2018-07-07 15:55:52 +00:00
2017-09-05 15:13:41 +00:00
2021-01-07 20:22:42 -07:00
2019-06-16 01:22:44 +00:00
2018-07-16 15:39:33 +00:00
2018-05-24 17:06:00 +00:00
2021-01-07 20:23:14 -07:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2019-01-25 13:48:40 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2017-05-25 04:18:46 +00:00
2020-10-11 16:01:16 +00:00
2020-10-02 18:18:01 +00:00
2018-01-22 08:33:59 +00:00
2018-01-21 21:27:41 +00:00
2020-02-03 17:35:11 +00:00
2018-01-12 12:14:14 +00:00
2018-11-01 23:11:47 +00:00
2019-12-20 19:53:05 +00:00
2018-02-12 22:21:11 +00:00
2018-05-19 04:46:34 +00:00
2020-03-15 17:40:14 +00:00
2020-02-03 17:35:11 +00:00
2019-12-16 21:34:51 +00:00
2018-01-18 22:01:30 +00:00
2020-02-13 19:25:49 +00:00
2018-07-17 23:23:45 +00:00
2018-02-22 19:12:32 +00:00
2020-08-25 13:30:03 +00:00
2020-08-25 13:30:03 +00:00
2020-02-13 19:25:49 +00:00
2020-08-01 09:06:16 +00:00
2020-01-22 23:28:42 +00:00
2020-10-10 01:13:14 +00:00
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2020-04-28 16:09:18 +00:00
2020-11-06 19:04:20 +00:00
2020-12-26 19:13:10 +01:00
2021-01-08 14:37:17 -08:00
2019-06-11 23:35:49 +00:00
2020-12-06 17:44:28 +00:00
2020-11-18 15:07:34 +00:00
2020-09-02 09:17:29 +00:00
2020-07-28 10:58:37 +00:00
2017-06-20 14:28:51 +00:00
2021-01-07 20:22:56 -07:00
2019-03-01 04:17:43 +00:00
2017-06-13 14:07:13 +00:00
2018-04-06 17:35:35 +00:00
2020-11-28 22:34:33 +00:00
2019-08-07 20:28:27 +00:00
2018-12-19 04:54:32 +00:00
2020-02-03 17:35:11 +00:00
2019-12-29 21:16:03 +00:00
2019-12-07 17:54:40 +00:00
2021-01-08 02:18:44 +03:00
2019-10-02 16:18:50 +00:00
2020-11-05 16:36:39 +00:00
2019-03-28 08:30:45 +00:00
2019-03-28 08:30:45 +00:00
2020-05-31 05:02:15 +00:00
2021-01-08 02:18:43 +03:00
2019-04-20 12:51:05 +00:00
2020-03-20 21:06:58 +00:00
2020-05-26 23:35:10 +00:00
2020-09-04 17:37:58 +00:00
2020-05-29 19:29:10 +00:00
2019-04-24 09:05:45 +00:00
2020-10-22 09:09:53 +00:00
2020-01-29 22:43:56 +00:00
2021-01-07 20:23:04 -07:00
2019-10-21 20:28:38 +00:00
2020-01-29 22:43:56 +00:00
2020-12-17 14:20:36 +00:00
2019-03-28 08:59:11 +00:00
2020-11-25 19:10:20 +00:00
2019-06-06 03:02:25 +00:00
2018-02-07 18:59:54 +00:00
2019-12-12 13:28:46 +00:00
2017-04-03 03:07:48 +00:00
2021-01-07 15:45:25 -04:00
2020-03-20 21:06:58 +00:00
2020-05-29 19:21:35 +00:00
2020-03-20 21:06:58 +00:00
2020-02-03 17:35:11 +00:00
2020-11-20 01:15:48 +00:00
2019-10-16 14:57:38 +00:00
2019-11-07 23:35:54 +00:00
2019-11-03 03:23:27 +00:00
2019-06-12 00:03:00 +00:00
2020-02-06 21:01:19 +00:00
2020-06-09 22:42:54 +00:00
2020-02-06 21:01:19 +00:00
2018-04-06 17:35:35 +00:00
2020-04-10 23:08:41 +00:00
2020-08-22 03:57:55 +00:00
2019-08-27 00:01:56 +00:00
2020-02-03 17:35:11 +00:00
2020-05-16 02:29:10 +00:00
2020-03-20 21:06:58 +00:00
2019-05-13 18:28:40 +00:00
2019-05-13 18:28:40 +00:00
2020-12-05 14:53:24 +00:00
2020-11-05 19:30:31 +00:00
2020-11-05 19:30:31 +00:00
2020-11-18 13:45:32 +00:00
2020-02-06 21:01:19 +00:00
2018-07-19 23:55:29 +00:00
2018-06-20 00:41:30 +00:00
2018-06-20 00:41:30 +00:00
2018-06-20 00:41:30 +00:00
2018-06-20 00:41:30 +00:00
2018-06-20 00:41:30 +00:00
2018-04-06 17:35:35 +00:00
2019-11-06 19:51:40 +00:00
2020-12-26 19:40:55 +01:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2020-03-20 21:06:58 +00:00
2017-07-09 17:02:47 +00:00
2017-05-08 20:58:32 +00:00
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2020-09-24 07:10:34 +00:00
2017-06-09 12:06:22 +00:00
2020-03-20 21:06:58 +00:00
2019-06-12 00:03:00 +00:00
2019-08-07 01:41:17 +00:00
2021-01-07 20:40:41 -07:00
2018-12-05 11:57:16 +00:00
2020-09-02 01:29:33 +00:00
2019-04-10 16:48:45 +00:00
2020-09-02 01:29:33 +00:00
2019-08-16 20:30:31 +00:00
2020-08-16 11:37:28 +00:00
2019-10-04 21:47:09 +00:00
2019-08-21 22:18:01 +00:00
2020-02-06 21:01:19 +00:00
2019-06-12 23:09:10 +00:00
2019-09-14 03:30:34 +00:00
2020-12-27 14:33:13 -08:00
2020-12-04 21:12:17 +00:00
2020-03-31 06:25:43 +00:00
2019-10-12 23:01:16 +00:00
2018-07-01 18:09:16 +00:00
2018-07-01 18:09:16 +00:00
2020-04-01 19:22:09 +00:00
2021-01-07 20:23:00 -07:00
2020-10-03 14:01:20 +00:00
2020-11-05 15:55:23 +00:00
2020-12-23 11:36:45 -05:00
2020-03-20 21:06:58 +00:00
2017-08-21 20:27:45 +00:00
2019-06-12 00:03:00 +00:00
2020-04-28 16:09:18 +00:00
2020-01-02 17:44:41 +00:00
2020-11-24 21:28:44 +00:00
2017-06-09 07:08:58 +00:00
2019-01-02 06:48:53 +00:00
2019-01-02 05:21:06 +00:00
2019-06-12 00:03:00 +00:00
2020-07-14 14:09:29 +00:00
2020-12-26 13:48:06 +01:00
2020-07-10 14:56:05 +00:00
2017-07-10 03:38:07 +00:00
2018-01-12 12:14:14 +00:00
2018-01-12 12:14:14 +00:00
2019-06-13 22:03:53 +00:00
2018-04-06 17:35:35 +00:00
2020-04-28 16:09:18 +00:00
2018-04-06 17:35:35 +00:00
2017-08-16 10:38:06 +00:00
2018-04-28 17:43:51 +00:00
2020-02-03 17:35:11 +00:00
2018-04-01 18:22:24 +00:00
2018-07-20 17:46:55 +00:00
2020-08-30 07:34:32 +00:00
2019-07-01 17:05:41 +00:00
2020-10-08 20:56:00 +00:00
2018-04-06 17:35:35 +00:00
2020-06-03 18:42:28 +00:00
2017-05-09 05:22:51 +00:00
2019-06-16 01:22:44 +00:00
2019-03-25 07:46:20 +00:00
2020-02-01 16:57:04 +00:00
2021-01-07 20:23:09 -07:00
2018-07-06 22:07:26 +00:00
2018-07-06 22:07:26 +00:00
2021-01-08 02:18:44 +03:00
2018-06-20 00:48:46 +00:00
2018-04-06 17:35:35 +00:00
2019-10-10 03:12:17 +00:00
2020-05-05 00:02:04 +00:00
2020-10-19 20:43:29 +00:00
2020-04-17 06:04:20 +00:00
2019-02-26 19:55:03 +00:00
2021-01-07 17:42:10 -08:00
2019-08-25 17:13:00 +00:00
2021-01-07 20:41:06 -07:00
f222a6b886