Conrad Meyer b483e111c4 kern_rctl: Fix resource leak in error path ...

Ordinarily, rctl_write_outbuf frees 'sb'.  However, if we are in low memory
conditions we skip past the rctl_write_outbuf.  In that case, free 'sb'.

Reported by:	Coverity
CID:		1338539
Sponsored by:	EMC / Isilon Storage Division

2016-04-20 02:09:38 +00:00

..

bus_if.m

Replace all resource occurrences of '0UL/~0UL' with '0/~0'.

2016-03-03 05:07:35 +00:00

capabilities.conf

Add futimens and utimensat system calls.

2015-01-23 21:07:08 +00:00

clock_if.m

…

cpufreq_if.m

…

device_if.m

Change the default method for device_quiesce() to return 0 instead of

2015-01-08 21:46:28 +00:00

genassym.sh

genassym.sh: call nm(1) with NMFLAGS.

2015-08-14 22:57:13 +00:00

imgact_aout.c

Implement vsyscall hack. Prior to 2.13 glibc uses vsyscall

2016-01-09 20:18:53 +00:00

imgact_binmisc.c

Repair a overflow condition where a user could submit a string that was

2016-04-01 16:16:26 +00:00

imgact_elf32.c

…

imgact_elf64.c

…

imgact_elf.c

Remove some NULL checks for M_WAITOK allocations.

2016-03-29 13:56:59 +00:00

imgact_gzip.c

Implement lockless resource limits.

2015-06-10 10:48:12 +00:00

imgact_shell.c

Allow multiple image activators to run on the same execution by changing

2014-09-04 21:31:25 +00:00

inflate.c

…

init_main.c

Rename P_KTHREAD struct proc p_flag to P_KPROC.

2016-02-09 16:30:16 +00:00

init_sysent.c

Regen.

2016-03-21 21:38:35 +00:00

kern_acct.c

…

kern_alq.c

Use SI_SUB_LAST instead of SI_SUB_SMP as the "catch-all" subsystem.

2016-03-11 23:18:06 +00:00

kern_clock.c

The struct thread td_estcpu member is only used by the 4BSD scheduler.

2016-04-17 11:04:27 +00:00

kern_clocksource.c

Fix typo in comment.

2015-07-20 09:37:42 +00:00

kern_condvar.c

Rework handling of thread sleeps before timers are working.

2016-03-31 18:10:29 +00:00

kern_conf.c

Provide yet another KPI for cdev creation, make_dev_s(9).

2016-01-07 20:08:02 +00:00

kern_cons.c

CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than ten

2015-05-22 17:05:21 +00:00

kern_context.c

…

kern_cpu.c

Pull in r267961 and r267973 again. Fix for issues reported will follow.

2014-06-28 03:56:17 +00:00

kern_cpuset.c

Add more fine-grained kernel options for NUMA support.

2016-04-09 13:58:04 +00:00

kern_ctf.c

Don't specify a resid parameter if we're just going to ignore it. Instead,

2015-02-20 20:49:00 +00:00

kern_descrip.c

The sendfile(2) allows to send extra data from userspace before the file

2016-03-29 19:57:11 +00:00

kern_dtrace.c

Commit the rest of the changes that were intended to be part of r266826.

2014-05-29 01:42:22 +00:00

kern_dump.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

kern_environment.c

Create wrappers for uint64_t and int64_t for the tunables. While not

2016-04-15 03:09:55 +00:00

kern_et.c

Trivial change / forced-commit to document prior change that slipped in

2015-03-16 19:29:19 +00:00

kern_event.c

Provide high precision conversion from ns,us,ms -> sbintime in kevent

2016-03-12 23:02:53 +00:00

kern_exec.c

Remove some NULL checks for M_WAITOK allocations.

2016-03-29 13:56:59 +00:00

kern_exit.c

session: avoid proctree lock on proc exit when possible

2016-01-20 23:33:58 +00:00

kern_fail.c

fail(9): Only gather/print stacks if STACK is enabled

2016-03-17 01:05:53 +00:00

kern_ffclock.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

kern_fork.c

Rename P_KTHREAD struct proc p_flag to P_KPROC.

2016-02-09 16:30:16 +00:00

kern_gzio.c

Move zlib.c from net to libkern.

2015-04-22 14:38:58 +00:00

kern_hhook.c

Check that hhk_helper pointer isn't NULL before access.

2015-11-25 07:14:58 +00:00

kern_idle.c

…

kern_intr.c

The part of r285680 which removed release semantic for two stores to

2015-07-21 14:39:34 +00:00

kern_jail.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

kern_khelp.c

…

kern_kthread.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

kern_ktr.c

Fix the logic in the ddb command 'show ktr /a'. Prior to r118269 it would

2016-01-31 17:32:20 +00:00

kern_ktrace.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

kern_linker.c

Remove some NULL checks for M_WAITOK allocations.

2016-03-29 13:56:59 +00:00

kern_lock.c

Don't modify curthread->td_locks unless INVARIANTS is enabled.

2015-08-02 00:03:08 +00:00

kern_lockf.c

Improve style and fix a possible use-after-free case introduced in r268384

2015-01-10 06:48:35 +00:00

kern_lockstat.c

Consistently use a reader/writer flag for lockstat probes in rwlock(9) and

2015-07-19 22:24:33 +00:00

kern_loginclass.c

Speed up rctl operation with large rulesets, by holding the lock

2015-11-15 12:10:51 +00:00

kern_malloc.c

Include sys/_task.h into uma_int.h, so that taskqueue.h isn't a

2016-02-09 20:22:35 +00:00

kern_mbuf.c

Plug leak in m_unshare.

2016-03-26 23:39:53 +00:00

kern_mib.c

Fix build after r295934.

2016-02-23 23:37:10 +00:00

kern_module.c

Provide better debug message on kernel module name clash.

2015-10-10 09:21:55 +00:00

kern_mtxpool.c

Garbage collect mtxpool_lockbuilder, the mutex pool historically used

2014-05-02 07:57:40 +00:00

kern_mutex.c

Don't modify curthread->td_locks unless INVARIANTS is enabled.

2015-08-02 00:03:08 +00:00

kern_ntptime.c

Use the monotonic (uptime) counter rather than time-of-day to measure elapsed

2015-07-12 18:38:17 +00:00

kern_numa.c

Add an initial NUMA affinity/policy configuration for threads and processes.

2015-07-11 15:21:37 +00:00

kern_osd.c

Add osd_reserve() and osd_set_reserved(), which allow M_WAITOK allocation

2016-03-30 16:57:28 +00:00

kern_physio.c

Add four new RCTL resources - readbps, readiops, writebps and writeiops,

2016-04-07 04:23:25 +00:00

kern_pmc.c

Pull in r267961 and r267973 again. Fix for issues reported will follow.

2014-06-28 03:56:17 +00:00

kern_poll.c

When a kernel has DEVICE_POLLING turned on but no drivers have

2015-04-14 14:22:34 +00:00

kern_priv.c

Pull in r267961 and r267973 again. Fix for issues reported will follow.

2014-06-28 03:56:17 +00:00

kern_proc.c

Use a loop instead of a goto in sysctl_kern_proc_kstack().

2016-04-17 23:22:32 +00:00

kern_procctl.c

If process becomes reaper (procctl(PROC_REAP_ACQUIRE)) while already

2015-08-20 22:44:26 +00:00

kern_prot.c

Call crextend() before copying old credentials to the new credentials

2016-01-14 10:16:25 +00:00

kern_racct.c

Allocate RACCT/RCTL zones without UMA_ZONE_NOFREE; no idea why it was there

2016-04-15 13:34:59 +00:00

kern_rangelock.c

…

kern_rctl.c

kern_rctl: Fix resource leak in error path

2016-04-20 02:09:38 +00:00

kern_resource.c

Implement process-shared locks support for libthr.so.3, without

2016-02-28 17:52:33 +00:00

kern_rmlock.c

Threads holding a read lock of a sleepable rm lock are not permitted

2015-09-15 22:16:21 +00:00

kern_rwlock.c

Don't modify curthread->td_locks unless INVARIANTS is enabled.

2015-08-02 00:03:08 +00:00

kern_sdt.c

…

kern_sema.c

…

kern_sendfile.c

The sendfile(2) allows to send extra data from userspace before the file

2016-03-29 19:57:11 +00:00

kern_sharedpage.c

Split kerne timekeep ABI structure vdso_sv_tk out of the struct

2015-11-23 07:09:35 +00:00

kern_shutdown.c

Add 4Kn kernel dump support

2016-04-15 17:45:12 +00:00

kern_sig.c

Add ptrace(2) reporting for LWP events.

2015-12-29 23:25:26 +00:00

kern_switch.c

Revert for r277213:

2015-01-22 11:12:42 +00:00

kern_sx.c

Don't modify curthread->td_locks unless INVARIANTS is enabled.

2015-08-02 00:03:08 +00:00

kern_synch.c

Rework handling of thread sleeps before timers are working.

2016-03-31 18:10:29 +00:00

kern_syscalls.c

Implement lockless resource limits.

2015-06-10 10:48:12 +00:00

kern_sysctl.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

kern_tc.c

Define fhard in pps_event(..) only when PPS_SYNC is defined to mute

2015-11-02 03:14:37 +00:00

kern_thr.c

Add ptrace(2) reporting for LWP events.

2015-12-29 23:25:26 +00:00

kern_thread.c

Call kern_thr_exit() instead of duplicating it.

2015-12-29 23:16:20 +00:00

kern_time.c

Verify that tv_sec value specified in settimeofday() and clock_settime()

2015-12-27 15:37:07 +00:00

kern_timeout.c

If callout_stop_safe() noted that the callout is currently executing,

2016-03-02 18:46:17 +00:00

kern_umtx.c

Fix umtx lock/trylock for compat32.

2016-04-19 11:37:43 +00:00

kern_uuid.c

…

kern_xxx.c

…

ksched.c

Use P1B_PRIO_MAX to designate max posix priority for the RR/FIFO

2015-08-30 18:02:57 +00:00

link_elf_obj.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

link_elf.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

linker_if.m

…

Make.tags.inc

Bring the tags and links entries for amd64 up to date.

2015-10-27 22:59:24 +00:00

Makefile

…

makesyscalls.sh

Do not include system call wrappers in libc for old FreeBSD system calls.

2016-03-12 22:53:46 +00:00

md4c.c

…

md5c.c

…

p1003_1b.c

In preparation for switching linuxulator to the use the native 1:1

2015-05-24 14:44:06 +00:00

pic_if.m

Remove FDT specific parts from INTRNG. Change its interface to make it

2016-04-04 09:15:25 +00:00

posix4_mib.c

Simplify AIO initialization now that it is standard.

2016-03-09 19:05:11 +00:00

sched_4bsd.c

The struct thread td_estcpu member is only used by the 4BSD scheduler.

2016-04-17 11:04:27 +00:00

sched_ule.c

The struct thread td_estcpu member is only used by the 4BSD scheduler.

2016-04-17 11:04:27 +00:00

serdev_if.m

…

stack_protector.c

Use nitems() macro instead of __arraycount()

2015-06-16 20:19:00 +00:00

subr_acl_nfs4.c

Expose an interface to determine if an ACE is inherited.

2015-09-04 00:14:20 +00:00

subr_acl_posix1e.c

…

subr_autoconf.c

…

subr_blist.c

…

subr_bufring.c

…

subr_bus_dma.c

Fix a bug introduced in r291716:

2016-01-11 20:38:39 +00:00

subr_bus.c

Add a function to lookup a device_t object by name.

2016-04-10 05:05:02 +00:00

subr_busdma_bufalloc.c

Fix printf format to allow for bus_size_t not being u_long on all platforms.

2015-10-20 03:25:17 +00:00

subr_capability.c

capsicum: plug spurious memset in __cap_rights_init

2015-12-01 02:48:42 +00:00

subr_clock.c

For architectures where time_t is wide enough, in particular, 64bit

2014-12-12 09:37:18 +00:00

subr_counter.c

Free the temporary buffer in sysctl_handle_counter_u64_array().

2016-03-15 00:21:32 +00:00

subr_devstat.c

Fix multiple incorrect SYSCTL arguments in the kernel:

2014-10-21 07:31:21 +00:00

subr_disk.c

…

subr_dummy_vdso_tc.c

Update the vdso timehands only via tc_windup().

2015-01-20 03:54:30 +00:00

subr_eventhandler.c

…

subr_fattime.c

Where appropriate, use the modern terms for the one true time base

2014-12-21 05:07:11 +00:00

subr_firmware.c

Create a dedicated function for ensuring that cdir and rdir are populated.

2015-07-11 16:22:48 +00:00

subr_hash.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

subr_hints.c

Add a new device control utility for new-bus devices called devctl. This

2015-02-06 16:09:01 +00:00

subr_intr.c

Fix intr_irq_shuffle(). After r297539, ISRCs doing IPI may be also

2016-04-07 15:16:33 +00:00

subr_kdb.c

Fix multiple incorrect SYSCTL arguments in the kernel:

2014-10-21 07:31:21 +00:00

subr_kobj.c

…

subr_lock.c

Add _NEW flag to mtx(9), sx(9), rmlock(9) and rwlock(9).

2014-12-13 21:00:10 +00:00

subr_log.c

…

subr_mbpool.c

All mbuf external free functions never fail, so let them be void.

2014-07-11 13:58:48 +00:00

subr_mchain.c

These files were getting sys/malloc.h and vm/uma.h with header pollution

2016-02-01 17:41:21 +00:00

subr_module.c

preload_search_info: make sure mod is set

2015-08-21 15:57:57 +00:00

subr_msgbuf.c

Pull in r267961 and r267973 again. Fix for issues reported will follow.

2014-06-28 03:56:17 +00:00

subr_param.c

Ensure that maxproc does not exceed pid_max, at the time of boot.

2015-09-21 15:02:59 +00:00

subr_pcpu.c

…

subr_pctrie.c

…

subr_power.c

…

subr_prf.c

Add vlog(9).

2015-11-19 05:50:22 +00:00

subr_prof.c

The process spin lock currently has the following distinct uses:

2014-11-26 14:10:00 +00:00

subr_rman.c

Use uintmax_t (typedef'd to rman_res_t type) for rman ranges.

2016-03-18 01:28:41 +00:00

subr_rtc.c

…

subr_sbuf.c

Fail the sbuf if vsnprintf(3) fails.

2015-10-02 09:23:14 +00:00

subr_scanf.c

…

subr_sfbuf.c

Move KASSERT into locked region.

2014-08-11 15:06:07 +00:00

subr_sglist.c

Fix a couple of panics when detaching from a cxgbe/cxl interface that was

2015-01-26 16:26:28 +00:00

subr_sleepqueue.c

Rework handling of thread sleeps before timers are working.

2016-03-31 18:10:29 +00:00

subr_smp.c

topo_set_pu_id: turn a check into an assertion

2016-04-08 11:59:11 +00:00

subr_stack.c

Add support for a configurable output channel to witness(4).

2015-11-19 05:56:59 +00:00

subr_syscall.c

Support an arbitrary number of arguments to DTrace syscall probes.

2015-12-17 00:00:27 +00:00

subr_taskqueue.c

Remove taskqueue_enqueue_fast().

2016-03-01 17:47:32 +00:00

subr_terminal.c

vt(4): Adjust the cursor position after changing the window size

2014-11-01 17:05:15 +00:00

subr_trap.c

Add four new RCTL resources - readbps, readiops, writebps and writeiops,

2016-04-07 04:23:25 +00:00

subr_turnstile.c

Finish r173600. There is no need to test a condition if both cases

2016-02-10 21:16:37 +00:00

subr_uio.c

Add asynchronous command support to the pass(4) driver, and the new

2015-12-03 20:54:55 +00:00

subr_unit.c

…

subr_vmem.c

CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than ten

2015-05-22 17:05:21 +00:00

subr_witness.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

sys_capability.c

Introduce kern_cap_rights_limit().

2015-08-11 08:43:50 +00:00

sys_generic.c

Cap IOSIZE_MAX to INT_MAX for 32-bit processes.

2016-04-01 18:29:38 +00:00

sys_pipe.c

Make pipes in CloudABI work.

2015-07-29 17:18:27 +00:00

sys_procdesc.c

The si_status field of the siginfo_t, provided by the waitid(2) and

2015-07-18 09:02:50 +00:00

sys_process.c

Add ptrace(2) reporting for LWP events.

2015-12-29 23:25:26 +00:00

sys_socket.c

Refactor the AIO subsystem to permit file-type-specific handling and

2016-03-01 18:12:14 +00:00

syscalls.c

Regen.

2016-03-21 21:38:35 +00:00

syscalls.master

Fully handle size_t lengths in AIO requests.

2016-03-21 21:37:33 +00:00

systrace_args.c

Regen.

2016-03-21 21:38:35 +00:00

sysv_ipc.c

…

sysv_msg.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

sysv_sem.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

sysv_shm.c

Change the default setting of kern.ipc.shm_allow_removed from 0 to 1.

2015-10-10 09:29:47 +00:00

tty_compat.c

…

tty_info.c

…

tty_inq.c

…

tty_outq.c

…

tty_pts.c

Implement lockless resource limits.

2015-06-10 10:48:12 +00:00

tty_tty.c

tty: replace several curthread->td_proc with stored curproc

2015-07-06 18:53:56 +00:00

tty_ttydisc.c

Don't clear the software flow control flag before draining for last

2016-01-26 14:46:39 +00:00

tty.c

Don't clear the software flow control flag before draining for last

2016-01-26 14:46:39 +00:00

uipc_accf.c

The accept filter code is not specific to the FreeBSD IPv4 network stack,

2014-07-26 19:27:34 +00:00

uipc_debug.c

Refactor the AIO subsystem to permit file-type-specific handling and

2016-03-01 18:12:14 +00:00

uipc_domain.c

CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than ten

2015-05-22 17:05:21 +00:00

uipc_mbuf2.c

Add const-qualifiers for source mbuf argument in m_dup(), m_copym(),

2015-08-08 15:50:46 +00:00

uipc_mbuf.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

uipc_mbufhash.c

Reduce header pollution.

2015-03-17 14:16:50 +00:00

uipc_mqueue.c

Clean up some style(9) violations.

2016-04-14 17:07:26 +00:00

uipc_sem.c

Clean up some style(9) violations.

2016-04-14 17:07:26 +00:00

uipc_shm.c

Clean up some style(9) violations.

2016-04-14 17:07:26 +00:00

uipc_sockbuf.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

uipc_socket.c

o "avaliable" -> "available".

2016-03-21 08:03:50 +00:00

uipc_syscalls.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

uipc_usrreq.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

vfs_acl.c

Replace struct filedesc argument in getvnode with struct thread

2015-06-16 13:09:18 +00:00

vfs_aio.c

Tidy up the unmapped I/O code in qphysio.

2016-03-31 17:27:30 +00:00

vfs_bio.c

Add four new RCTL resources - readbps, readiops, writebps and writeiops,

2016-04-07 04:23:25 +00:00

vfs_cache.c

Provide more correct sizing of the KVA consumed by a vnode, used by

2016-02-24 15:15:46 +00:00

vfs_cluster.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

vfs_default.c

Simplify AIO initialization now that it is standard.

2016-03-09 19:05:11 +00:00

vfs_export.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

vfs_extattr.c

Replace struct filedesc argument in getvnode with struct thread

2015-06-16 13:09:18 +00:00

vfs_hash.c

Track changes to kern.maxvnodes and appropriately increase or decrease

2015-09-06 05:50:51 +00:00

vfs_init.c

sysctl: switch sysctllock to a sleepable rmlock, take 2

2015-09-15 23:06:56 +00:00

vfs_lookup.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

vfs_mount.c

Do not copy by field when converting struct oexport_args to struct

2016-02-04 16:32:21 +00:00

vfs_mountroot.c

Wait for root mount tokens before showing the root mount prompt.

2016-03-22 13:46:01 +00:00

vfs_subr.c

Provide more correct sizing of the KVA consumed by a vnode, used by

2016-02-24 15:15:46 +00:00

vfs_syscalls.c

Simplify AIO initialization now that it is standard.

2016-03-09 19:05:11 +00:00

vfs_vnops.c

Cleanup unnecessary semicolons from the kernel.

2016-04-10 23:07:00 +00:00

vnode_if.src

A change to KPI of vm_pager_get_pages() and underlying VOP_GETPAGES().

2015-12-16 21:30:45 +00:00