d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- In rw_wunlock_hard prefer to wakeup writers if there are both readers

Browse Source 
and writers available.  Doing otherwise can cause deadlocks as no
   read locks can proceed while there are write waiters.

Sponsored by:	Nokia
This commit is contained in:
jeff 2008-02-07 06:16:54 +00:00
parent 4a600fdd88
commit 005506bb32
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/kern/kern_rwlock.c
View File

@ -679,11 +679,11 @@ _rw_wunlock_hard(struct rwlock *rw, uintptr_t tid, const char *file, int line)
* of waiters or doing some complicated lock handoff gymnastics. * of waiters or doing some complicated lock handoff gymnastics.
*/ */
v = RW_UNLOCKED; v = RW_UNLOCKED;
if (rw->rw_lock & RW_LOCK_READ_WAITERS) { if (rw->rw_lock & RW_LOCK_WRITE_WAITERS) {
queue = TS_SHARED_QUEUE;
v |= (rw->rw_lock & RW_LOCK_WRITE_WAITERS);
} else
queue = TS_EXCLUSIVE_QUEUE; queue = TS_EXCLUSIVE_QUEUE;
v |= (rw->rw_lock & RW_LOCK_READ_WAITERS);
} else
queue = TS_SHARED_QUEUE;
/* Wake up all waiters for the specific queue. */ /* Wake up all waiters for the specific queue. */
if (LOCK_LOG_TEST(&rw->lock_object, 0)) if (LOCK_LOG_TEST(&rw->lock_object, 0))