d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the following clang 4.0.0 warning in ngatm's snmp_atm.c:

Browse Source 
contrib/ngatm/snmp_atm/snmp_atm.c:173:6: error: logical not is only
    applied to the left hand side of this bitwise operator
    [-Werror,-Wlogical-not-parentheses]
            if (!ifmr.ifm_status & IFM_AVALID) {
                ^                ~

Obviously, the masking needs to be done before the logical not
operation.  Add parentheses to make it so.

MFC after:      3 days
This commit is contained in:
Dimitry Andric 2017-01-07 15:57:12 +00:00
parent d4cd50b494
commit 00742f6ced
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/ngatm/snmp_atm/snmp_atm.c
View File

@ -170,7 +170,7 @@ atmif_check_carrier(struct atmif_priv *aif)
aif->pub.carrier = ATMIF_CARRIER_UNKNOWN;
return;
}
if (!ifmr.ifm_status & IFM_AVALID) {
if (!(ifmr.ifm_status & IFM_AVALID)) {
aif->pub.carrier = ATMIF_CARRIER_UNKNOWN;
return;
}