d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ioat(4): Recheck status register on zero-descriptor wakeups

Browse Source 
Errors that halt the channel don't necessarily result in a completion
update, apparently.

Sponsored by:	EMC / Isilon Storage Division
This commit is contained in:
Conrad Meyer 2016-02-13 02:55:45 +00:00
parent 3ce83dbfcf
commit 007a703036
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/dev/ioat/ioat.c
View File

@ -630,8 +630,14 @@ ioat_process_events(struct ioat_softc *ioat)
CTR0(KTR_IOAT, __func__);
if (status == ioat->last_seen)
if (status == ioat->last_seen) {
/*
* If we landed in process_events and nothing has been
* completed, check for a timeout due to channel halt.
*/
comp_update = ioat_get_chansts(ioat);
goto out;
}
while (1) {
desc = ioat_get_ring_entry(ioat, ioat->tail);
@ -661,8 +667,10 @@ out:
ioat_write_chanctrl(ioat, IOAT_CHANCTRL_RUN);
mtx_unlock(&ioat->cleanup_lock);
ioat_putn(ioat, completed, IOAT_ACTIVE_DESCR_REF);
wakeup(&ioat->tail);
if (completed != 0) {
ioat_putn(ioat, completed, IOAT_ACTIVE_DESCR_REF);
wakeup(&ioat->tail);
}
if (!is_ioat_halted(comp_update))
return;