d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

default to doing lla_lookup with shared afdata lock and returning a

Browse Source 
shared lock on the lle - thus restoring parallel performance to
pre-arpv2 level
This commit is contained in:
Kip Macy 2008-12-17 00:14:28 +00:00
parent 991f8615e4
commit 00a46b3122
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sys/netinet/if_ether.c
View File

@ -251,7 +251,7 @@ arpresolve(struct ifnet *ifp, struct rtentry *rt0, struct mbuf *m,
{ {
INIT_VNET_INET(ifp->if_vnet); INIT_VNET_INET(ifp->if_vnet);
struct llentry *la = 0; struct llentry *la = 0;
u_int flags; u_int flags = 0;
int error, renew; int error, renew;
*lle = NULL; *lle = NULL;
@ -268,18 +268,19 @@ arpresolve(struct ifnet *ifp, struct rtentry *rt0, struct mbuf *m,
return (0); return (0);
} }
} }
flags = (ifp->if_flags & (IFF_NOARP | IFF_STATICARP)) ? 0 : LLE_CREATE;
/* XXXXX /* XXXXX
* Since this function returns an llentry, the
* lock is held by the caller.
* XXX if caller is required to hold lock, assert it
*/ */
retry: retry:
IF_AFDATA_LOCK(ifp); IF_AFDATA_RLOCK(ifp);
la = lla_lookup(LLTABLE(ifp), flags, dst); la = lla_lookup(LLTABLE(ifp), flags, dst);
IF_AFDATA_UNLOCK(ifp); IF_AFDATA_RUNLOCK(ifp);
if ((la == NULL) && ((flags & LLE_EXCLUSIVE) == 0)
&& ((ifp->if_flags & (IFF_NOARP | IFF_STATICARP)) == 0)) {
flags |= (LLE_CREATE | LLE_EXCLUSIVE);
IF_AFDATA_WLOCK(ifp);
la = lla_lookup(LLTABLE(ifp), flags, dst);
IF_AFDATA_WUNLOCK(ifp);
}
if (la == NULL) { if (la == NULL) {
if (flags & LLE_CREATE) if (flags & LLE_CREATE)
log(LOG_DEBUG, log(LOG_DEBUG,