pcg-c: Add 'static' to inline function definitions

Browse Source

Make the inlines static to avoid kernel build failure with Clang 11 on i386.
(The issue was not observed with Clang 10, currently in tree; reproduction
depends on compiler inlining choices.)

The compiler may choose not to inline 'bare' C inlines, and in that case
expects a symbol of the same name will be available.  It does not
automatically define that symbol at use, because of traditional C linking
semantics. (In contrast, C++ does define it, and then deduplicates redundant
definitions at link).  As we do not instantiate the C99 inline ('extern
inline ...;'), the linker errors with "undefined symbol."

Reported by:	dim
Tested by:	dim
Fixes:		r364219

...

This commit is contained in:

cem 2020-08-15 18:46:26 +00:00

parent 45f58a2d89

commit 03a2f473c5

1 changed files with 238 additions and 238 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

476

sys/contrib/pcg-c/include/pcg_variants.h

File diff suppressed because it is too large Load Diff