d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't spindown the BSP if it executes hlt with the APIC disabled. A

Browse Source 
guest that doesn't use the APIC at all can trigger this, plus the BSP
always needs to execute as it should trigger a reset, etc.

Reviewed by:	tychon
This commit is contained in:
jhb 2014-04-15 20:53:53 +00:00
parent 2dd1becd9b
commit 03a8cfa7d9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/amd64/vmm/vmm.c
View File

@ -1036,10 +1036,12 @@ vm_handle_hlt(struct vm *vm, int vcpuid, bool intr_disabled, bool *retu)
msleep_spin(vcpu, &vcpu->mtx, "vmidle", timo);
} else {
/*
* Spindown the vcpu if the apic is disabled and it
* had entered the halted state.
* Spindown the vcpu if the APIC is disabled and it
* had entered the halted state, but never spin
* down the BSP.
*/
spindown = 1;
if (vcpuid != 0)
spindown = 1;
}
vcpu_require_state_locked(vcpu, VCPU_FROZEN);
vmm_stat_incr(vm, vcpuid, VCPU_IDLE_TICKS, ticks - t);