d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change two KASSERTS to printfs and simple returns. Stress testing has

Browse Source 
revealed that a process' current working directory can be VBAD if the
directory is removed.  This can trigger a panic when procstat -f PID is
run.

Tested by:	pho
Discovered by:	phobot
Reviewed by:	kib
Approved by:	kib
This commit is contained in:
Joe Marcus Clarke 2009-02-14 21:12:24 +00:00
parent a049439079
commit 03fd9c2092
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/kern/kern_descrip.c
View File

@ -2532,7 +2532,12 @@ export_vnode_for_osysctl(struct vnode *vp, int type,
kif->kf_fd = type; kif->kf_fd = type;
kif->kf_type = KF_TYPE_VNODE; kif->kf_type = KF_TYPE_VNODE;
/* This function only handles directories. */ /* This function only handles directories. */
KASSERT(vp->v_type == VDIR, ("export_vnode_for_osysctl: vnode not directory")); if (vp->v_type != VDIR) {
printf("export_vnode_for_osysctl: vnode not directory: %d\n",
vp->v_type);
vrele(vp);
return (ENOTDIR);
}
kif->kf_vnode_type = KF_VTYPE_VDIR; kif->kf_vnode_type = KF_VTYPE_VDIR;
/* /*
@ -2779,7 +2784,12 @@ export_vnode_for_sysctl(struct vnode *vp, int type,
kif->kf_fd = type; kif->kf_fd = type;
kif->kf_type = KF_TYPE_VNODE; kif->kf_type = KF_TYPE_VNODE;
/* This function only handles directories. */ /* This function only handles directories. */
KASSERT(vp->v_type == VDIR, ("export_vnode_for_sysctl: vnode not directory")); if (vp->v_type != VDIR) {
printf("export_vnode_for_sysctl: vnode not directory: %d\n",
vp->v_type);
vrele(vp);
return (ENOTDIR);
}
kif->kf_vnode_type = KF_VTYPE_VDIR; kif->kf_vnode_type = KF_VTYPE_VDIR;
/* /*