From 04ae5bbe551351c498bf135849acdf318f3334db Mon Sep 17 00:00:00 2001 From: Zbigniew Bodek Date: Wed, 19 Aug 2015 11:45:45 +0000 Subject: [PATCH] Remove redundant mp_naps from ARM64 secondary CPU start-up code The global variable has been only used for CPU startup ordering which is not needed anyway. Obtained from: Semihalf Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D3296 --- sys/arm64/arm64/mp_machdep.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/arm64/arm64/mp_machdep.c b/sys/arm64/arm64/mp_machdep.c index 469627e550d4..b95b2ed0789c 100644 --- a/sys/arm64/arm64/mp_machdep.c +++ b/sys/arm64/arm64/mp_machdep.c @@ -94,8 +94,6 @@ void init_secondary(uint64_t); uint8_t secondary_stacks[MAXCPU - 1][PAGE_SIZE * KSTACK_PAGES] __aligned(16); -/* # of Applications processors */ -volatile int mp_naps; /* Set to 1 once we're ready to let the APs out of the pen. */ volatile int aps_ready = 0; @@ -211,16 +209,6 @@ init_secondary(uint64_t cpu) "mov x18, %0 \n" "msr tpidr_el1, %0" :: "r"(pcpup)); - /* - * pcpu_init() updates queue, so it should not be executed in parallel - * on several cores - */ - while(mp_naps < (cpu - 1)) - ; - - /* Signal our startup to BSP */ - atomic_add_rel_32(&mp_naps, 1); - /* Spin until the BSP releases the APs */ while (!aps_ready) __asm __volatile("wfe");