d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove an XXXRW comment relating to whether or not the TCP timers are

Browse Source 
MPSAFE: they are now believed to be.

Correct a typo in a second comment.

MFC after:	2 weeks
This commit is contained in:
Robert Watson 2004-12-23 01:27:13 +00:00
parent db0aae38b6
commit 06da46b241
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/netinet/tcp_subr.c
View File

@ -596,11 +596,6 @@ tcp_newtcpcb(inp)
tcp_mssdflt;
/* Set up our timeouts. */
/*
* XXXRW: Are these actually MPSAFE? I think so, but need to
* review the timed wait code, as it has some list variables,
* etc, that are global.
*/
callout_flag = debug_mpsafenet ? CALLOUT_MPSAFE : 0;
callout_init(tp->tt_rexmt = &tm->tcpcb_mem_rexmt, callout_flag);
callout_init(tp->tt_persist = &tm->tcpcb_mem_persist, callout_flag);
@ -1708,7 +1703,7 @@ tcp_twstart(tp)
* that it is safe to recycle this tw socket by returning 1.
*
* XXXRW: This function should assert the inpcb lock as it does multiple
* non-atomic reads from the tcptw, but is currently * called without it from
* non-atomic reads from the tcptw, but is currently called without it from
* in_pcb.c:in_pcblookup_local().
*/
int

7
sys/netinet/tcp_timewait.c
View File

@ -596,11 +596,6 @@ tcp_newtcpcb(inp)
tcp_mssdflt;
/* Set up our timeouts. */
/*
* XXXRW: Are these actually MPSAFE? I think so, but need to
* review the timed wait code, as it has some list variables,
* etc, that are global.
*/
callout_flag = debug_mpsafenet ? CALLOUT_MPSAFE : 0;
callout_init(tp->tt_rexmt = &tm->tcpcb_mem_rexmt, callout_flag);
callout_init(tp->tt_persist = &tm->tcpcb_mem_persist, callout_flag);
@ -1708,7 +1703,7 @@ tcp_twstart(tp)
* that it is safe to recycle this tw socket by returning 1.
*
* XXXRW: This function should assert the inpcb lock as it does multiple
* non-atomic reads from the tcptw, but is currently * called without it from
* non-atomic reads from the tcptw, but is currently called without it from
* in_pcb.c:in_pcblookup_local().
*/
int