d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent a division by zero with some broken batteries

Browse Source 
This problem was seen on a laptop with a dead battery.
This commit is contained in:
dumbbell 2011-11-26 13:43:50 +00:00
parent 85d58c8854
commit 06e8068f72
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/acpica/acpi_battery.c
View File

@ -205,6 +205,14 @@ acpi_battery_get_battinfo(device_t dev, struct acpi_battinfo *battinfo)
bif->lfcap = (bif->lfcap * bif->dvol) / 1000;
}
/*
* The calculation above may set bif->lfcap to zero. This was
* seen on a laptop with a broken battery. The result of the
* division was rounded to zero.
*/
if (!acpi_battery_bif_valid(bif))
continue;
/* Calculate percent capacity remaining. */
bi[i].cap = (100 * bst[i].cap) / bif->lfcap;