Make sure that installing a module complains if the target modules
directory does not exist, instead of creating/overwriting a file with the name of the (expected) directory. Yes, this deviates a bit from nearly all other install targets in the tree, but let's face it, removing a modules directory is not all that uncommon a mistake, and finding a file with the contents of the last module installed is a baaad surprise at boot time.. PR: 26317 Submitted by: "T. William Wells" <bill@twwells.com> (the PR) Gregory Bond <gnb@itga.com.au> (the actual patch) Reviewed by: silence on -arch and -audit for the last 10 days MFC after: 2 weeks
This commit is contained in:
parent
0906f6dada
commit
06fdcd5035
@ -205,7 +205,7 @@ _INSTALLFLAGS:= ${_INSTALLFLAGS${ie}}
|
||||
|
||||
realinstall: _SUBDIR
|
||||
${INSTALL} ${COPY} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \
|
||||
${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}
|
||||
${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}/
|
||||
.if defined(LINKS) && !empty(LINKS)
|
||||
@set ${LINKS}; \
|
||||
while test $$# -ge 2; do \
|
||||
|
Loading…
Reference in New Issue
Block a user