d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add logging of executed mailbox command names.

Browse Source 
Previously those commands were logged only as part of register dump,
that is not very readable.
This commit is contained in:
mav 2015-06-22 06:30:02 +00:00
parent f034eccb76
commit 09034dd934
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/isp/isp.c
View File

@ -7344,6 +7344,7 @@ isp_mboxcmd(ispsoftc_t *isp, mbreg_t *mbp)
isp_prt(isp, ISP_LOGERR, "Unknown Command 0x%x", opcode); isp_prt(isp, ISP_LOGERR, "Unknown Command 0x%x", opcode);
return; return;
} }
cname = fc_mbcmd_names[opcode];
ibits = ISP_FC_IBITS(opcode); ibits = ISP_FC_IBITS(opcode);
obits = ISP_FC_OBITS(opcode); obits = ISP_FC_OBITS(opcode);
} else { } else {
@ -7352,9 +7353,15 @@ isp_mboxcmd(ispsoftc_t *isp, mbreg_t *mbp)
isp_prt(isp, ISP_LOGERR, "Unknown Command 0x%x", opcode); isp_prt(isp, ISP_LOGERR, "Unknown Command 0x%x", opcode);
return; return;
} }
cname = scsi_mbcmd_names[opcode];
ibits = ISP_SCSI_IBITS(opcode); ibits = ISP_SCSI_IBITS(opcode);
obits = ISP_SCSI_OBITS(opcode); obits = ISP_SCSI_OBITS(opcode);
} }
if (cname == NULL) {
cname = tname;
ISP_SNPRINTF(tname, sizeof tname, "opcode %x", opcode);
}
isp_prt(isp, ISP_LOGDEBUG3, "Mailbox Command '%s'", cname);
/* /*
* Pick up any additional bits that the caller might have set. * Pick up any additional bits that the caller might have set.
@ -7440,11 +7447,6 @@ isp_mboxcmd(ispsoftc_t *isp, mbreg_t *mbp)
if (mbp->logval == 0 || opcode == MBOX_EXEC_FIRMWARE) { if (mbp->logval == 0 || opcode == MBOX_EXEC_FIRMWARE) {
return; return;
} }
cname = (IS_FC(isp))? fc_mbcmd_names[opcode] : scsi_mbcmd_names[opcode];
if (cname == NULL) {
cname = tname;
ISP_SNPRINTF(tname, sizeof tname, "opcode %x", opcode);
}
/* /*
* Just to be chatty here... * Just to be chatty here...