d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Expect WhenDynamicCastToTest.AmbiguousCast to fail on FreeBSD

Browse Source 
Casting `AmbiguousCastTypes::DerivedSub1` to `Base` currently succeeds, when
it's expected to fail.

See https://github.com/google/googletest/issues/2172 for more details.
This commit is contained in:
ngie 2019-03-11 02:57:00 +00:00
parent 27c30212da
commit 0b1eecec7d
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
contrib/googletest/googlemock/test/gmock-matchers_test.cc
View File

@ -3767,6 +3767,12 @@ TEST(WhenDynamicCastToTest, AmbiguousCast) {
AmbiguousCastTypes::DerivedSub1 sub1;
AmbiguousCastTypes::ManyDerivedInHierarchy many_derived;
// Multiply derived from Base. dynamic_cast<> returns NULL.
// This testcase fails on FreeBSD. See this GitHub issue for more details:
// https://github.com/google/googletest/issues/2172
#ifdef __FreeBSD__
EXPECT_NONFATAL_FAILURE({
#endif
Base* as_base_ptr =
static_cast<AmbiguousCastTypes::DerivedSub1*>(&many_derived);
EXPECT_THAT(as_base_ptr,
@ -3775,6 +3781,9 @@ TEST(WhenDynamicCastToTest, AmbiguousCast) {
EXPECT_THAT(
as_base_ptr,
WhenDynamicCastTo<AmbiguousCastTypes::VirtualDerived*>(Not(IsNull())));
#ifdef __FreeBSD__
}, "");
#endif
}
TEST(WhenDynamicCastToTest, Describe) {