d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nm: avoid crash in print_lineno if func->name is NULL

Browse Source 
This can occur when DW_AT_specification is used to refer to another DIE
that provides the actual DW_AT_name string. For example:

< 3><0x00000086> DW_TAG_subprogram
                   DW_AT_name              PrettyStackTraceEntry
...
< 1><0x00002cf4> DW_TAG_subprogram
                   DW_AT_specification     <0x00000086>

We will need to add support for DW_AT_specification, but in the interim
we should not segfault.

Obtained from:	Elftoolchain (r3170)
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Ed Maste 2015-02-25 21:43:09 +00:00
parent 39b86a6a6f
commit 0b93a0b462
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/elftoolchain/nm/nm.c
View File

@ -1525,7 +1525,8 @@ print_lineno(struct sym_entry *ep, struct func_info_head *func_info,
/* For function symbol, search the function line information list. */ /* For function symbol, search the function line information list. */
if ((ep->sym->st_info & 0xf) == STT_FUNC && func_info != NULL) { if ((ep->sym->st_info & 0xf) == STT_FUNC && func_info != NULL) {
SLIST_FOREACH(func, func_info, entries) { SLIST_FOREACH(func, func_info, entries) {
if (!strcmp(ep->name, func->name) && if (func->name != NULL &&
!strcmp(ep->name, func->name) &&
ep->sym->st_value >= func->lowpc && ep->sym->st_value >= func->lowpc &&
ep->sym->st_value < func->highpc) { ep->sym->st_value < func->highpc) {
printf("\t%s:%" PRIu64, func->file, func->line); printf("\t%s:%" PRIu64, func->file, func->line);