d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AArch64: Don't set flush-subnormals-to-zero flag on startup

Browse Source 
This flag has been set on startup since 65618fdda0.
However, This causes some of the math-related tests to fail as they report
zero instead of a tiny number. This fixes at least
/usr/tests/lib/msun/ldexp_test and possibly others.
Additionally, setting this flag prevents printf() from printing subnormal
numbers in decimal form.
See also https://www.openwall.com/lists/musl/2021/02/26/1

PR:		253847
Reviewed By:	mmel
Differential Revision: https://reviews.freebsd.org/D28938
This commit is contained in:
Alex Richardson 2021-03-01 14:27:30 +00:00
parent 10f2a0c2e8
commit 0e4ff0acbe
2 changed files with 35 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/libc/tests/stdio/printfloat_test.c
View File

@ -50,7 +50,7 @@ smash_stack(void)
{ {
static uint32_t junk = 0xdeadbeef; static uint32_t junk = 0xdeadbeef;
uint32_t buf[512]; uint32_t buf[512];
int i; size_t i;
for (i = 0; i < sizeof(buf) / sizeof(buf[0]); i++) for (i = 0; i < sizeof(buf) / sizeof(buf[0]); i++)
buf[i] = junk; buf[i] = junk;
@ -370,6 +370,37 @@ ATF_TC_BODY(hexadecimal_rounding, tc)
testfmt("0x1.83p+0", "%.2a", 1.51); testfmt("0x1.83p+0", "%.2a", 1.51);
} }
ATF_TC_WITHOUT_HEAD(subnormal_double);
ATF_TC_BODY(subnormal_double, tc)
{
/* Regression test for https://bugs.freebsd.org/253847 */
double positive = __DBL_DENORM_MIN__;
testfmt("4.9406564584124654418e-324", "%20.20g", positive);
testfmt("4.9406564584124654418E-324", "%20.20G", positive);
testfmt("0x1p-1074", "%a", positive);
testfmt("0X1P-1074", "%A", positive);
double negative = -__DBL_DENORM_MIN__;
testfmt("-4.9406564584124654418e-324", "%20.20g", negative);
testfmt("-4.9406564584124654418E-324", "%20.20G", negative);
testfmt("-0x1p-1074", "%a", negative);
testfmt("-0X1P-1074", "%A", negative);
}
ATF_TC_WITHOUT_HEAD(subnormal_float);
ATF_TC_BODY(subnormal_float, tc)
{
float positive = __FLT_DENORM_MIN__;
testfmt("1.4012984643248170709e-45", "%20.20g", positive);
testfmt("1.4012984643248170709E-45", "%20.20G", positive);
testfmt("0x1p-149", "%a", positive);
testfmt("0X1P-149", "%A", positive);
float negative = -__FLT_DENORM_MIN__;
testfmt("-1.4012984643248170709e-45", "%20.20g", negative);
testfmt("-1.4012984643248170709E-45", "%20.20G", negative);
testfmt("-0x1p-149", "%a", negative);
testfmt("-0X1P-149", "%A", negative);
}
ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TCS(tp)
{ {
@ -384,6 +415,8 @@ ATF_TP_ADD_TCS(tp)
ATF_TP_ADD_TC(tp, decimal_rounding); ATF_TP_ADD_TC(tp, decimal_rounding);
ATF_TP_ADD_TC(tp, hexadecimal_floating_point); ATF_TP_ADD_TC(tp, hexadecimal_floating_point);
ATF_TP_ADD_TC(tp, hexadecimal_rounding); ATF_TP_ADD_TC(tp, hexadecimal_rounding);
ATF_TP_ADD_TC(tp, subnormal_double);
ATF_TP_ADD_TC(tp, subnormal_float);
return (atf_no_error()); return (atf_no_error());
} }

2
sys/arm64/arm64/vm_machdep.c
View File

@ -55,7 +55,7 @@ __FBSDID("$FreeBSD$");
#include <machine/vfp.h> #include <machine/vfp.h>
#endif #endif
uint32_t initial_fpcr = VFPCR_DN | VFPCR_FZ; uint32_t initial_fpcr = VFPCR_DN;
#include <dev/psci/psci.h> #include <dev/psci/psci.h>