From 0e533c72bc300bd90390e950ea9e473b38eeb409 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Mon, 24 Aug 2020 16:06:11 +0000 Subject: [PATCH] When copying over the binaries, use '-p' to preserve date/time Although I can't reproduce it, others are seeing different lex/yacc programs always regenerated after my change to copy rather than symlink the files. The reported fix is to add '-p' to the copies. Since it doesn't hurt, go head and add it, though the reasons for this mattering remain at best obscure and poorly articulated. --- Makefile.inc1 | 2 +- tools/build/Makefile | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.inc1 b/Makefile.inc1 index 3a6e19e733df..851d20ba1f60 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -2319,7 +2319,7 @@ ${_bt}-link-${_tool}: .PHONY .MAKE if [ ! -e "$${source_path}" ] ; then \ echo "Cannot find host tool '${_tool}'"; false; \ fi; \ - cp -f "$${source_path}" "${WORLDTMP}/legacy/bin/${_tool}" + cp -pf "$${source_path}" "${WORLDTMP}/legacy/bin/${_tool}" ${_bt}-links: ${_bt}-link-${_tool} .endfor diff --git a/tools/build/Makefile b/tools/build/Makefile index 23bd6cc1896f..9a5db708bb2f 100644 --- a/tools/build/Makefile +++ b/tools/build/Makefile @@ -130,7 +130,7 @@ host-symlinks: echo "Cannot find host tool '${_tool}'"; false; \ fi; \ rm -f "${DESTDIR}/bin/${_tool}"; \ - cp -f "$${source_path}" "${DESTDIR}/bin/${_tool}" + cp -pf "$${source_path}" "${DESTDIR}/bin/${_tool}" .endfor .for _tool in ${_host_abs_tools_to_symlink} @source_path="${_tool:S/:/ /:[1]}"; \ @@ -139,11 +139,11 @@ host-symlinks: echo "Host tool '${src_path}' is missing"; false; \ fi; \ rm -f "$${target_path}"; \ - cp -f "$${source_path}" "$${target_path}" + cp -pf "$${source_path}" "$${target_path}" .endfor .if exists(/usr/libexec/flua) rm -f ${DESTDIR}/usr/libexec/flua - cp -f /usr/libexec/flua ${DESTDIR}/usr/libexec/flua + cp -pf /usr/libexec/flua ${DESTDIR}/usr/libexec/flua .endif # Create all the directories that are needed during the legacy, bootstrap-tools