d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a case of undefined behavior due to overlapping buf objects in

Browse Source 
snprintf (buf, size, fmt, buf, etc). This only works by chance with our
libc, but fails (with a truncated string) on e.g. glibc.

Okayed by:	sobomax
MFC after:	1 week
This commit is contained in:
schweikh 2003-12-23 15:01:12 +00:00
parent 79e51fd0d7
commit 0e961ee647
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
usr.sbin/pkg_install/lib/match.c
View File

@ -236,13 +236,14 @@ int
isinstalledpkg(const char *name)
{
char buf[FILENAME_MAX];
char buf2[FILENAME_MAX];
snprintf(buf, sizeof(buf), "%s/%s", LOG_DIR, name);
if (!isdir(buf) || access(buf, R_OK) == FAIL)
return FALSE;
snprintf(buf, sizeof(buf), "%s/%s", buf, CONTENTS_FNAME);
if (!isfile(buf) || access(buf, R_OK) == FAIL)
snprintf(buf2, sizeof(buf2), "%s/%s", buf, CONTENTS_FNAME);
if (!isfile(buf2) || access(buf2, R_OK) == FAIL)
return FALSE;
return TRUE;