d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warnings found by Coverity.

Browse Source 
Found with:   Coverity Prevent(tm)
MFC after:	1 month
This commit is contained in:
fabient 2010-06-05 22:57:53 +00:00
parent 28122090a3
commit 0ecf60c0b7
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/pmcstat/pmcpl_calltree.c
View File

@ -896,10 +896,12 @@ pmcpl_ct_node_printchild(struct pmcpl_ct_node *ct)
/* Call address, line, sample. */
addr = ct->pct_image->pi_vaddr + ct->pct_func;
line = 0;
pmcstat_image_addr2line(ct->pct_image, addr, sourcefile,
if (pmcstat_image_addr2line(ct->pct_image, addr, sourcefile,
sizeof(sourcefile), &line,
funcname, sizeof(funcname));
fprintf(args.pa_graphfile, "%p %u", (void *)addr, line);
funcname, sizeof(funcname)))
fprintf(args.pa_graphfile, "%p %u", (void *)addr, line);
else
fprintf(args.pa_graphfile, "* *");
}
else
fprintf(args.pa_graphfile, "* *");

3
usr.sbin/pmcstat/pmcstat.c
View File

@ -292,7 +292,8 @@ pmcstat_find_targets(const char *spec)
0, &nproc)) == NULL)
err(EX_OSERR, "ERROR: Cannot get process list: %s",
kvm_geterr(pmcstat_kvm));
}
} else
nproc = 0;
if ((rv = regcomp(&reg, spec, REG_EXTENDED|REG_NOSUB)) != 0) {
regerror(rv, &reg, errbuf, sizeof(errbuf));

1
usr.sbin/pmcstat/pmcstat_log.c
View File

@ -1957,6 +1957,7 @@ pmcstat_keypress_log(void)
case 'q':
wprintw(w, "exiting...");
ret = 1;
break;
default:
if (plugins[args.pa_plugin].pl_topkeypress != NULL)
if (plugins[args.pa_plugin].pl_topkeypress(c, w))