d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Do not raise IFF_DRV_OACTIVE flag in vlan_start, because this

Browse Source 
can lead to stalled interface
- Explain this fact in a comment.

Reviewed by:	rwatson, thompsa, yar
This commit is contained in:
glebius 2005-11-06 19:43:04 +00:00
parent 6daa19f5d4
commit 0ed33a8df1
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/net/if_vlan.c
View File

@ -465,6 +465,14 @@ vlan_ifinit(void *foo)
}
/*
* The if_start method for vlan(4) interface. It doesn't
* raises the IFF_DRV_OACTIVE flag, since it is called
* only from IFQ_HANDOFF() macro in ether_output_frame().
* If the interface queue is full, and vlan_start() is
* not called, the queue would never get emptied and
* interface would stall forever.
*/
static void
vlan_start(struct ifnet *ifp)
{
@ -477,7 +485,6 @@ vlan_start(struct ifnet *ifp)
ifv = ifp->if_softc;
p = ifv->ifv_p;
ifp->if_drv_flags |= IFF_DRV_OACTIVE;
for (;;) {
IF_DEQUEUE(&ifp->if_snd, m);
if (m == 0)
@ -561,7 +568,6 @@ vlan_start(struct ifnet *ifp)
else
ifp->if_oerrors++;
}
ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
}
static void