d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Return error when opening read-only volumes (like RAID4/5/...) for writing.

Browse Source 
Previously opens succeeded, but actual write operations returned errors.

Requested by:	peter
MFC after:	2 weeks
This commit is contained in:
Alexander Motin 2013-08-13 07:56:40 +00:00
parent 0dc59c0fac
commit 0f0b2fd889
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/geom/raid/g_raid.c
View File

@ -1863,6 +1863,11 @@ g_raid_access(struct g_provider *pp, int acr, int acw, int ace)
error = ENXIO;
goto out;
}
/* Deny write opens for read-only volumes. */
if (vol->v_read_only && acw > 0) {
error = EROFS;
goto out;
}
if (dcw == 0)
g_raid_clean(vol, dcw);
vol->v_provider_open += acr + acw + ace;

1
sys/geom/raid/g_raid.h
View File

@ -306,6 +306,7 @@ struct g_raid_volume {
int v_stopping; /* Volume is stopping */
int v_provider_open; /* Number of opens. */
int v_global_id; /* Global volume ID (rX). */
int v_read_only; /* Volume is read-only. */
TAILQ_ENTRY(g_raid_volume) v_next; /* List of volumes entry. */
LIST_ENTRY(g_raid_volume) v_global_next; /* Global list entry. */
};

3
sys/geom/raid/tr_raid5.c
View File

@ -185,8 +185,9 @@ g_raid_tr_start_raid5(struct g_raid_tr_object *tr)
struct g_raid_volume *vol;
trs = (struct g_raid_tr_raid5_object *)tr;
vol = tr->tro_volume;
trs->trso_starting = 0;
vol = tr->tro_volume;
vol->v_read_only = 1;
g_raid_tr_update_state_raid5(vol, NULL);
return (0);
}