d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check return code of setuid(), setgid(), and setgroups() in rwhod.

Browse Source 
While they will not fail in normal circumstances, better safe than
sorry.

MFC after:	1 week
This commit is contained in:
Simon L. B. Nielsen 2011-04-23 13:42:03 +00:00
parent 04e7229db5
commit 11522ca501
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
usr.sbin/rwhod/rwhod.c
View File

@ -248,9 +248,18 @@ main(int argc, char *argv[])
syslog(LOG_ERR, "bind: %m");
exit(1);
}
setgid(unpriv_gid);
setgroups(1, &unpriv_gid); /* XXX BOGUS groups[0] = egid */
setuid(unpriv_uid);
if (setgid(unpriv_gid) != 0) {
syslog(LOG_ERR, "setgid: %m");
exit(1);
}
if (setgroups(1, &unpriv_gid) != 0) { /* XXX BOGUS groups[0] = egid */
syslog(LOG_ERR, "setgroups: %m");
exit(1);
}
if (setuid(unpriv_uid) != 0) {
syslog(LOG_ERR, "setuid: %m");
exit(1);
}
if (!configure(s))
exit(1);
if (!quiet_mode) {