When comparing device IDs, make sure that they have the same type
(like NAA assigned) and identify the same entity (like device or port). Otherwise there can be false positives since at least some models of Seagate disks use same IDs for the whole device and one of its ports. MFC after: 2 weeks
This commit is contained in:
parent
1fd1edcf18
commit
11dca5fed3
@ -6509,7 +6509,11 @@ scsi_devid_match(uint8_t *lhs, size_t lhs_len, uint8_t *rhs, size_t rhs_len)
|
||||
while (rhs_id <= rhs_last
|
||||
&& (rhs_id->identifier + rhs_id->length) <= rhs_end) {
|
||||
|
||||
if (rhs_id->length == lhs_id->length
|
||||
if ((rhs_id->id_type &
|
||||
(SVPD_ID_ASSOC_MASK | SVPD_ID_TYPE_MASK)) ==
|
||||
(lhs_id->id_type &
|
||||
(SVPD_ID_ASSOC_MASK | SVPD_ID_TYPE_MASK))
|
||||
&& rhs_id->length == lhs_id->length
|
||||
&& memcmp(rhs_id->identifier, lhs_id->identifier,
|
||||
rhs_id->length) == 0)
|
||||
return (0);
|
||||
|
Loading…
Reference in New Issue
Block a user