d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

regulator: Check status before disabling

Browse Source 
When disabling regulator when they are unused, check before is they are
enabled.
While here don't check the enable_cnt on the regulator entry as it is
checked by regnode_stop.
This solve the panic on any board using a fixed regulator that is driven
by a gpio when the regulator is unused.

Tested On: OrangePi One
Pointy Hat to:	    myself
Reported by:	kevans, Milan Obuch (freebsd-arm@dino.sk)
This commit is contained in:
manu 2018-04-20 20:30:33 +00:00
parent 8897e4c4c3
commit 13193780b0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/extres/regulator/regulator.c
View File

@ -166,17 +166,19 @@ static void
regulator_shutdown(void *dummy)
{
struct regnode *entry;
int status, ret;
int disable = 1;
REG_TOPO_SLOCK();
TUNABLE_INT_FETCH("hw.regulator.disable_unused", &disable);
TAILQ_FOREACH(entry, &regnode_list, reglist_link) {
if (entry->enable_cnt == 0 &&
entry->std_param.always_on == 0 && disable) {
if (entry->std_param.always_on == 0 && disable) {
if (bootverbose)
printf("regulator: shuting down %s\n",
entry->name);
regnode_stop(entry, 0);
ret = regnode_status(entry, &status);
if (ret == 0 && status == REGULATOR_STATUS_ENABLED)
regnode_stop(entry, 0);
}
}
REG_TOPO_UNLOCK();