Remove an obsolete TODO comment from several minidump implementations.

The comment referenced a non-existent function, and these minidump
implementations already buffer discontiguous physical data pages by
mapping them into a single VA range that gets passed to the dump device,
so there is no real advantage in batching calls to blk_write().

The RISC-V and MIPS minidump implementations still write a page at a
time and so would benefit from some form of batching.

MFC after:	2 weeks
Sponsored by:	Juniper Networks, Klara Inc.
This commit is contained in:
markj 2020-04-24 18:47:42 +00:00
parent 34552d79cf
commit 143b039d73
4 changed files with 0 additions and 4 deletions

View File

@ -409,7 +409,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
/* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {

View File

@ -374,7 +374,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
/* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {

View File

@ -321,7 +321,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
/* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {

View File

@ -381,7 +381,6 @@ minidumpsys(struct dumperinfo *di)
dump_total("pmap", pmapsize);
/* Dump memory chunks */
/* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
/* TODO optimize with bit manipulation instructions */