d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove ptei->value check from ipfw_link_table_values():

Browse Source 
even if there was non-zero number of restarts, we would unref/clear
  all value references and start ipfw_link_table_values() once again
  with (mostly) cleared "tei" buffer.
 Additionally, ptei->ptv stores only to-be-added values, not existing ones.
 This is a forgotten piece of previous value refconting implementation,
  and now it is simply incorrect.
This commit is contained in:
melifaro 2015-05-12 20:42:42 +00:00
parent f7a28383ef
commit 1493021aa5
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/netpfil/ipfw/ip_fw_table_value.c
View File

@ -563,17 +563,6 @@ ipfw_link_table_values(struct ip_fw_chain *ch, struct tableop_state *ts)
/* Let's try to link values */
for (i = 0; i < count; i++) {
ptei = &tei[i];
if (ptei->value != 0) {
/*
* We may be here after several process restarts,
* so we need to update all fields that might
* have changed.
*/
ptv = (struct table_val_link *)ptei->ptv;
ptv->pval = &pval[i];
continue;
}
/* Check if record has appeared */
mask_table_value(ptei->pvalue, &tval, ts->vmask);