d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When printing ACLs, truncate user and group names if they're too long,

Browse Source 
rather than generating an error.  This is consistent with other tools
printing user and group names, and means you can read the ACL using
our tools rather than being up a creek.

PR:		56991
Submitted by:	Michael Bretterklieber <mbretter@a-quadrat.at>
This commit is contained in:
Robert Watson 2003-11-03 21:00:16 +00:00
parent 4c4c0f9144
commit 14a276b3fe
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/libc/posix1e/acl_support.c
View File

@ -241,7 +241,9 @@ _posix1e_acl_check(acl_t acl)
/*
* Given a uid/gid, return a username/groupname for the text form of an ACL
* Given a uid/gid, return a username/groupname for the text form of an ACL.
* Note that we truncate user and group names, rather than error out, as
* this is consistent with other tools manipulating user and group names.
* XXX NOT THREAD SAFE, RELIES ON GETPWUID, GETGRGID
* XXX USES *PW* AND *GR* WHICH ARE STATEFUL AND THEREFORE THIS ROUTINE
* MAY HAVE SIDE-EFFECTS
@ -261,7 +263,7 @@ _posix1e_acl_id_to_name(acl_tag_t tag, uid_t id, ssize_t buf_len, char *buf)
else
i = snprintf(buf, buf_len, "%s", p->pw_name);
if (i < 0 || i >= buf_len) {
if (i < 0) {
errno = ENOMEM;
return (-1);
}
@ -274,7 +276,7 @@ _posix1e_acl_id_to_name(acl_tag_t tag, uid_t id, ssize_t buf_len, char *buf)
else
i = snprintf(buf, buf_len, "%s", g->gr_name);
if (i < 0 || i >= buf_len) {
if (i < 0) {
errno = ENOMEM;
return (-1);
}