d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable disabled googletest-port-test tests after r363820

Browse Source 
gtest now links against libregex here, and the tests pass locally.

PR:		248452
This commit is contained in:
Kyle Evans 2020-08-04 02:20:15 +00:00
parent b4af4f93c6
commit 1546dc216f
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/googletest/googletest/test/googletest-port-test.cc
View File

@ -403,8 +403,6 @@ typedef testing::Types<
TYPED_TEST_CASE(RETest, StringTypes); TYPED_TEST_CASE(RETest, StringTypes);
// Tests RE's implicit constructors. // Tests RE's implicit constructors.
/*
https://bugs.freebsd.org/248452
TYPED_TEST(RETest, ImplicitConstructorWorks) { TYPED_TEST(RETest, ImplicitConstructorWorks) {
const RE empty(TypeParam("")); const RE empty(TypeParam(""));
EXPECT_STREQ("", empty.pattern()); EXPECT_STREQ("", empty.pattern());
@ -415,7 +413,6 @@ TYPED_TEST(RETest, ImplicitConstructorWorks) {
const RE normal(TypeParam(".*(\\w+)")); const RE normal(TypeParam(".*(\\w+)"));
EXPECT_STREQ(".*(\\w+)", normal.pattern()); EXPECT_STREQ(".*(\\w+)", normal.pattern());
} }
*/
// Tests that RE's constructors reject invalid regular expressions. // Tests that RE's constructors reject invalid regular expressions.
TYPED_TEST(RETest, RejectsInvalidRegex) { TYPED_TEST(RETest, RejectsInvalidRegex) {
@ -864,8 +861,6 @@ TEST(MatchRegexAnywhereTest, ReturnsTrueWhenMatchingNonPrefix) {
} }
// Tests RE's implicit constructors. // Tests RE's implicit constructors.
/*
https://bugs.freebsd.org/248452
TEST(RETest, ImplicitConstructorWorks) { TEST(RETest, ImplicitConstructorWorks) {
const RE empty(""); const RE empty("");
EXPECT_STREQ("", empty.pattern()); EXPECT_STREQ("", empty.pattern());
@ -873,7 +868,6 @@ TEST(RETest, ImplicitConstructorWorks) {
const RE simple("hello"); const RE simple("hello");
EXPECT_STREQ("hello", simple.pattern()); EXPECT_STREQ("hello", simple.pattern());
} }
*/
// Tests that RE's constructors reject invalid regular expressions. // Tests that RE's constructors reject invalid regular expressions.
TEST(RETest, RejectsInvalidRegex) { TEST(RETest, RejectsInvalidRegex) {