d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move the "sti" instruction to right before the "hlt" to close a tiny

Browse Source 
race condition.

Obtained from:	bde and/or obrien
This commit is contained in:
phk 2000-01-02 15:18:12 +00:00
parent 0a3cb76ffd
commit 169381ef73
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/amd64/amd64/cpu_switch.S
View File

@ -174,7 +174,6 @@ idle_loop:
/* enable intrs for a halt */
movl $0, lapic_tpr /* 1st candidate for an INT */
sti
call *_hlt_vector /* wait for interrupt */
cli
jmp idle_loop
@ -243,7 +242,6 @@ idle_loop:
call _vm_page_zero_idle
testl %eax, %eax
jnz idle_loop
sti
call *_hlt_vector /* wait for interrupt */
jmp idle_loop
@ -252,6 +250,7 @@ idle_loop:
CROSSJUMPTARGET(_idle)
ENTRY(default_halt)
sti
#ifndef SMP
hlt /* XXX: until a wakeup IPI */
#endif

3
sys/amd64/amd64/swtch.s
View File

@ -174,7 +174,6 @@ idle_loop:
/* enable intrs for a halt */
movl $0, lapic_tpr /* 1st candidate for an INT */
sti
call *_hlt_vector /* wait for interrupt */
cli
jmp idle_loop
@ -243,7 +242,6 @@ idle_loop:
call _vm_page_zero_idle
testl %eax, %eax
jnz idle_loop
sti
call *_hlt_vector /* wait for interrupt */
jmp idle_loop
@ -252,6 +250,7 @@ idle_loop:
CROSSJUMPTARGET(_idle)
ENTRY(default_halt)
sti
#ifndef SMP
hlt /* XXX: until a wakeup IPI */
#endif

3
sys/i386/i386/swtch.s
View File

@ -174,7 +174,6 @@ idle_loop:
/* enable intrs for a halt */
movl $0, lapic_tpr /* 1st candidate for an INT */
sti
call *_hlt_vector /* wait for interrupt */
cli
jmp idle_loop
@ -243,7 +242,6 @@ idle_loop:
call _vm_page_zero_idle
testl %eax, %eax
jnz idle_loop
sti
call *_hlt_vector /* wait for interrupt */
jmp idle_loop
@ -252,6 +250,7 @@ idle_loop:
CROSSJUMPTARGET(_idle)
ENTRY(default_halt)
sti
#ifndef SMP
hlt /* XXX: until a wakeup IPI */
#endif