d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usr.sbin/services_mkdb: plug memory leak when line was blank.

Browse Source 
Reviewed by:	bapt
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D29370
This commit is contained in:
Xin LI 2021-03-30 15:21:37 -07:00
parent 660045fb53
commit 18f3c5fe92
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
usr.sbin/services_mkdb/uniq.c
View File

@ -120,12 +120,13 @@ comp(const char *origline, char **compline, size_t *len)
for (p = (const unsigned char *)origline; l && *p && isspace(*p);
p++, l--)
continue;
if (*p == '\0' || l == 0)
return 0;
if ((cline = malloc(l + 1)) == NULL)
err(1, "Cannot allocate %zu bytes", l + 1);
(void)memcpy(cline, p, l);
cline[l] = '\0';
if (*cline == '\0')
return 0;
complen = 0;
hasalnum = 0;
@ -155,6 +156,11 @@ comp(const char *origline, char **compline, size_t *len)
--complen;
}
*q = '\0';
if (!hasalnum) {
free(cline);
cline = NULL;
complen = 0;
}
*compline = cline;
*len = complen;
return hasalnum;